rust/compiler/rustc_parse/src/parser/path.rs, branch 1.74.0

inline format!() args up to and including rustc_middle

2023-07-30T11:18:33+00:00

Rollup merge of #110791 - compiler-errors:negative-bounds, r=oli-obk

2023-05-03T18:47:23+00:00

Implement negative bounds for internal testing purposes Implements partial support the `!` negative polarity on trait bounds. This is incomplete, but should allow us to at least be able to play with the feature. Not even gonna consider them as a public-facing feature, but I'm implementing them because would've been nice to have in UI tests, for example in #110671.

Restrict `From` for `{D,Subd}iagnosticMessage`.

2023-05-02T22:44:39+00:00
Currently a `{D,Subd}iagnosticMessage` can be created from any type that impls `Into`. That includes `&str`, `String`, and `Cow<'static, str>`, which are reasonable. It also includes `&String`, which is pretty weird, and results in many places making unnecessary allocations for patterns like this: ``` self.fatal(&format!(...)) ``` This creates a string with `format!`, takes a reference, passes the reference to `fatal`, which does an `into()`, which clones the reference, doing a second allocation. Two allocations for a single string, bleh. This commit changes the `From` impls so that you can only create a `{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static, str>`. This requires changing all the places that currently create one from a `&String`. Most of these are of the `&format!(...)` form described above; each one removes an unnecessary static `&`, plus an allocation when executed. There are also a few places where the existing use of `&String` was more reasonable; these now just use `clone()` at the call site. As well as making the code nicer and more efficient, this is a step towards possibly using `Cow<'static, str>` in `{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing the `From<&'a str>` impls to `From<&'static str>`, which is doable, but I'm not yet sure if it's worthwhile.

Implement negative bounds

2023-05-02T22:36:24+00:00

soften the wording for removing type ascription

2023-05-01T08:37:00+00:00

fix tests

2023-05-01T08:15:17+00:00

clean up debug code

2023-05-01T08:15:17+00:00

Rip it out

2023-05-01T08:15:13+00:00
My type ascription Oh rip it out Ah If you think we live too much then You can sacrifice diagnostics Don't mix your garbage Into my syntax So many weird hacks keep diagnostics alive Yet I don't even step outside So many bad diagnostics keep tyasc alive Yet tyasc doesn't even bother to survive!

Migrate trivially translatable `rustc_parse` diagnostics

2023-04-27T00:53:06+00:00

Fix static string lints

2023-04-25T17:59:55+00:00