rust/compiler/rustc_parse/src/parser, branch 1.49.0

Don't allow `const` to begin a nonterminal

2020-12-27T17:26:00+00:00

Thanks to Vadim Petrochenkov who [told me what the fix was][z]! [z]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/finding.20which.20macro.20rule.20to.20use/near/220240422

Rollup merge of #78836 - fanzier:struct-and-slice-destructuring, r=petrochenkov

2020-11-12T18:46:09+00:00

Implement destructuring assignment for structs and slices This is the second step towards implementing destructuring assignment (RFC: rust-lang/rfcs#2909, tracking issue: #71126). This PR is the second part of #71156, which was split up to allow for easier review. Note that the first PR (#78748) is not merged yet, so it is included as the first commit in this one. I thought this would allow the review to start earlier because I have some time this weekend to respond to reviews. If ``@petrochenkov`` prefers to wait until the first PR is merged, I totally understand, of course. This PR implements destructuring assignment for (tuple) structs and slices. In order to do this, the following *parser change* was necessary: struct expressions are not required to have a base expression, i.e. `Struct { a: 1, .. }` becomes legal (in order to act like a struct pattern). Unfortunately, this PR slightly regresses the diagnostics implemented in #77283. However, it is only a missing help message in `src/test/ui/issues/issue-77218.rs`. Other instances of this diagnostic are not affected. Since I don't exactly understand how this help message works and how to fix it yet, I was hoping it's OK to regress this temporarily and fix it in a follow-up PR. Thanks to ``@varkor`` who helped with the implementation, particularly around the struct rest changes. r? ``@petrochenkov``

Auto merge of #78782 - petrochenkov:nodoctok, r=Aaron1011

2020-11-12T00:33:55+00:00

Do not collect tokens for doc comments Doc comment is a single token and AST has all the information to re-create it precisely. Doc comments are also responsible for majority of calls to `collect_tokens` (with `num_calls == 1` and `num_calls == 0`, cc https://github.com/rust-lang/rust/pull/78736). (I also moved token collection into `fn parse_attribute` to deduplicate code a bit.) r? `@Aaron1011`

Implement destructuring assignment for structs and slices

2020-11-11T12:10:52+00:00

Co-authored-by: varkor

Rollup merge of #78710 - petrochenkov:macvisit, r=davidtwco

2020-11-09T18:06:55+00:00

rustc_ast: Do not panic by default when visiting macro calls Panicking by default made sense when we didn't have HIR or MIR and everything worked on AST, but now all AST visitors run early and majority of them have to deal with macro calls, often by ignoring them. The second commit renames `visit_mac` to `visit_mac_call`, the corresponding structures were renamed earlier in https://github.com/rust-lang/rust/pull/69589.

Do not collect tokens for doc comments

2020-11-08T22:47:11+00:00

rustc_ast: `visit_mac` -> `visit_mac_call`

2020-11-03T20:39:51+00:00

rustc_ast: Do not panic by default when visiting macro calls

2020-11-03T17:38:20+00:00

Use reparsed `TokenStream` if we captured any inner attributes

2020-11-02T18:22:03+00:00

Fixes #78675 We now bail out of `prepend_attrs` if we ended up capturing any inner attributes (which can happen in several places, due to token capturing for `macro_rules!` arguments.

parser: Cleanup `LazyTokenStream` and avoid some clones

2020-10-30T22:56:34+00:00

by using a named struct instead of a closure.