rust/compiler/rustc_pattern_analysis/src/errors.rs, branch cargo_updatehttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=cargo_update2025-05-07T01:53:55+00:00error early when mixing deref patterns with normal constructors2025-05-07T01:53:55+00:00diannediannes.gm@gmail.com2025-04-21T06:57:09+00:00urn:sha1:fb261a179d2c210785b6e9005201e262dac801b5
Without adding proper support for mixed exhaustiveness, mixing deref
patterns with normal constructors would either violate
`ConstructorSet::split`'s invariant 4 or 7. We'd either be ignoring rows
with normal constructors or we'd have problems in unspecialization from
non-disjoint constructors. Checking mixed exhaustivenss similarly to how
unions are currently checked should work, but the diagnostics for unions
are confusing. Since mixing deref patterns with normal constructors is
pretty niche (currently it only makes sense for `Cow`), emitting an
error lets us avoid committing to supporting mixed exhaustiveness
without a good answer for the diagnostics.
Move eager translation to a method on `Diag`2025-04-17T01:38:59+00:00Jake Gouldingjake.goulding@gmail.com2025-03-21T14:09:17+00:00urn:sha1:01178849174bdff3e3e951827d9ea4884c23b758
This will allow us to eagerly translate messages on a top-level
diagnostic, such as a `LintDiagnostic`. As a bonus, we can remove the
awkward closure passed into Subdiagnostic and make better use of
`Into`.
Encapsulate the printing of `WitnessPat`2024-07-29T04:56:50+00:00ZalatharZalathar@users.noreply.github.com2024-07-28T05:14:26+00:00urn:sha1:db05b0fd343e8204460b0e1f3e261cc4ae940e0a
This hides the fact that we print `WitnessPat` by converting it to `thir::Pat`
and then printing that.
Don't store `thir::Pat` in error structs2024-07-28T11:58:44+00:00ZalatharZalathar@users.noreply.github.com2024-07-28T05:12:14+00:00urn:sha1:e1fc4a997ddac2b949ef6bb4037f1fb196c44f08
In several cases this avoids the need to clone the underlying pattern, and then
print the clone later.
Pass translation closure to add_to_diag_with() as reference2024-04-21T07:45:03+00:00Xiretzaxiretza@xiretza.xyz2024-04-18T19:18:35+00:00urn:sha1:5646b65cf58123679fdf4ef489f690d1b21e1436Rename `RustcMatchCheckCtxt` -> `RustcPatCtxt`2024-03-13T13:07:44+00:00Nadrierilnadrieril+git@gmail.com2024-03-13T13:07:44+00:00urn:sha1:f27540697e7f17b77dd2fae9fe5d9df8a5eb24c0Rename `AddToDiagnostic` as `Subdiagnostic`.2024-03-10T23:04:49+00:00Nicholas Nethercoten.nethercote@gmail.com2024-03-06T03:00:16+00:00urn:sha1:541d7cc65c56402f31335e41075838c0da5fbe01
To match `derive(Subdiagnostic)`.
Also rename `add_to_diagnostic{,_with}` as `add_to_diag{,_with}`.
Lint small gaps between ranges2024-03-09T00:14:22+00:00Nadrierilnadrieril+git@gmail.com2024-01-14T21:24:10+00:00urn:sha1:8ac9a04257f73d9861625816d4c741096dd69c67Rename `SubdiagnosticMessageOp` as `SubdiagMessageOp`.2024-03-05T01:14:49+00:00Nicholas Nethercoten.nethercote@gmail.com2024-02-29T05:18:19+00:00urn:sha1:573267cf3c10c13f4cb3b9935affd05925d938d0Rename `DiagnosticBuilder` as `Diag`.2024-02-27T21:55:35+00:00Nicholas Nethercoten.nethercote@gmail.com2024-02-22T23:20:45+00:00urn:sha1:899cb40809a85eb9d89f6da3268713b83175360a
Much better!
Note that this involves renaming (and updating the value of)
`DIAGNOSTIC_BUILDER` in clippy.