rust/compiler/rustc_pattern_analysis/src, branch 1.89.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.89.02025-05-28T10:03:01+00:00Use `builin_index` instead of hand-rolling it2025-05-28T10:03:01+00:00Oli Scherergithub333195615777966@oli-obk.de2025-05-26T10:38:02+00:00urn:sha1:550aed825b3a630b5b2bd235e193bfce065268c2Revert "Fix stack overflow in exhaustiveness due to recursive HIR opaque type values"2025-05-20T10:09:01+00:00Michael Gouletmichael@errs.io2025-04-28T19:41:37+00:00urn:sha1:47b9e373cba69d66da9f91345219ff4f07eba84a
This reverts commit b08e9c2a60f4dbab4bdaa733727947b3395de329.
Remove #![feature(let_chains)] from library and src/librustdoc2025-05-16T14:14:24+00:00est31MTest31@outlook.com2025-05-13T13:10:51+00:00urn:sha1:258e8808616e4cb5c65d2692c66a6c61e17cc09ferror early when mixing deref patterns with normal constructors2025-05-07T01:53:55+00:00diannediannes.gm@gmail.com2025-04-21T06:57:09+00:00urn:sha1:fb261a179d2c210785b6e9005201e262dac801b5
Without adding proper support for mixed exhaustiveness, mixing deref
patterns with normal constructors would either violate
`ConstructorSet::split`'s invariant 4 or 7. We'd either be ignoring rows
with normal constructors or we'd have problems in unspecialization from
non-disjoint constructors. Checking mixed exhaustivenss similarly to how
unions are currently checked should work, but the diagnostics for unions
are confusing. Since mixing deref patterns with normal constructors is
pretty niche (currently it only makes sense for `Cow`), emitting an
error lets us avoid committing to supporting mixed exhaustiveness
without a good answer for the diagnostics.
let deref patterns participate in usefulness/exhaustiveness2025-05-07T01:53:55+00:00diannediannes.gm@gmail.com2025-04-17T09:33:24+00:00urn:sha1:b41d8bde00930d80f07b7aa90cc0a8e6bd423413
This does not yet handle the case of mixed deref patterns with normal
constructors; it'll ICE in `Constructor::is_covered_by`. That'll be
fixed in a later commit.
Make #![feature(let_chains)] bootstrap conditional in compiler/2025-04-23T14:40:30+00:00est31MTest31@outlook.com2025-04-23T13:51:57+00:00urn:sha1:7493e1cdf64b381f7eb910da982fcbbad7d64769Move eager translation to a method on `Diag`2025-04-17T01:38:59+00:00Jake Gouldingjake.goulding@gmail.com2025-03-21T14:09:17+00:00urn:sha1:01178849174bdff3e3e951827d9ea4884c23b758
This will allow us to eagerly translate messages on a top-level
diagnostic, such as a `LintDiagnostic`. As a bonus, we can remove the
awkward closure passed into Subdiagnostic and make better use of
`Into`.
Fix stack overflow in exhaustiveness due to recursive HIR opaque type values2025-04-07T22:41:48+00:00Michael Gouletmichael@errs.io2025-04-07T22:32:49+00:00urn:sha1:b08e9c2a60f4dbab4bdaa733727947b3395de329Rollup merge of #139035 - nnethercote:PatKind-Missing, r=oli-obk2025-04-07T12:29:17+00:00Stuart CookZalathar@users.noreply.github.com2025-04-07T12:29:17+00:00urn:sha1:82df6229b6383ba1395eb0599309b30e257c3c3b
Add new `PatKind::Missing` variants
To avoid some ugly uses of `kw::Empty` when handling "missing" patterns, e.g. in bare fn tys. Helps with #137978. Details in the individual commits.
r? ``@oli-obk``
Auto merge of #138785 - lcnr:typing-mode-borrowck, r=compiler-errors,oli-obk2025-04-04T19:54:42+00:00borsbors@rust-lang.org2025-04-04T19:54:42+00:00urn:sha1:17ffbc81a30c094193836a5d7f90dff273b5df93
add `TypingMode::Borrowck`
Shares the first commit with #138499, doesn't really matter which PR to land first :blush: :grin:
Introduces `TypingMode::Borrowck` which unlike `TypingMode::Analysis`, uses the hidden type computed by HIR typeck as the initial value of opaques instead of an unconstrained infer var. This is a part of https://github.com/rust-lang/types-team/issues/129.
Using this new `TypingMode` is unfortunately a breaking change for now, see tests/ui/impl-trait/non-defining-uses/as-projection-term.rs. Using an inference variable as the initial value results in non-defining uses in the defining scope. We therefore only enable it if with `-Znext-solver=globally` or `-Ztyping-mode-borrowck`
To do that the PR contains the following changes:
- `TypeckResults::concrete_opaque_type` are already mapped to the definition of the opaque type
- writeback now checks that the non-lifetime parameters of the opaque are universal
- for this, `fn check_opaque_type_parameter_valid` is moved from `rustc_borrowck` to `rustc_trait_selection`
- we add a new `query type_of_opaque_hir_typeck` which, using the same visitors as MIR typeck, attempts to merge the hidden types from HIR typeck from all defining scopes
- done by adding a `DefiningScopeKind` flag to toggle between using borrowck and HIR typeck
- the visitors stop checking that the MIR type matches the HIR type. This is trivial as the HIR type are now used as the initial hidden types of the opaque. This check is useful as a safeguard when not using `TypingMode::Borrowck`, but adding it to the new structure is annoying and it's not soundness critical, so I intend to not add it back.
- add a `TypingMode::Borrowck` which behaves just like `TypingMode::Analysis` except when normalizing opaque types
- it uses `type_of_opaque_hir_typeck(opaque)` as the initial value after replacing its regions with new inference vars
- it uses structural lookup in the new solver
fixes #112201, fixes #132335, fixes #137751
r? `@compiler-errors` `@oli-obk`