rust/compiler/rustc_pattern_analysis/src, branch betahttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=beta2025-08-23T20:22:15+00:00Rollup merge of #145234 - dianne:1-tuple-witnesses, r=jackh7262025-08-23T20:22:15+00:00Samuel Tardieusam@rfc1149.net2025-08-23T20:22:15+00:00urn:sha1:5a14685a63b8306367c3fdd49717113e9ba0ba59
match exhaustiveness diagnostics: show a trailing comma on singleton tuple consructors in witness patterns (and clean up a little)
Constructor patterns of type `(T,)` are written `(pat,)`, not `(pat)`. However, exhaustiveness/usefulness diagnostics would print them as `(pat)` when e.g. providing a witness of non-exhaustiveness and suggesting adding arms to make matches exhaustive; this would result in an error when applied.
rust-analyzer already prints the trailing comma, so it doesn't need changing.
This also includes some cleanup in the second commit, with justification in the commit message.
avoid unnecessary type sanity checks2025-08-14T07:44:22+00:00Ralf Jungpost@ralfj.de2025-07-29T15:22:22+00:00urn:sha1:e2cc7757e1bdbe8c9dc0dcffc1017ceff4799899shrink TestBranch::Constant and PatRangeBoundary::Finite2025-08-14T07:44:22+00:00Ralf Jungpost@ralfj.de2025-07-29T11:28:47+00:00urn:sha1:dbc030e0346f0958bea91601de7d115554bbf74echange StrLit type to ty::Value as well2025-08-14T07:44:22+00:00Ralf Jungpost@ralfj.de2025-07-29T07:01:05+00:00urn:sha1:a1acbfb050675f197fd525c830203f07412148bduse ty::Value instead of manual pairs of types and valtrees2025-08-14T07:44:22+00:00Ralf Jungpost@ralfj.de2025-07-29T06:54:34+00:00urn:sha1:a171eaab4249f70d24904da7ed392476b516a0e6pattern testing: store constants as valtrees2025-08-14T07:44:19+00:00Ralf Jungpost@ralfj.de2025-07-28T16:16:47+00:00urn:sha1:d61fdbf266cf25ddf8c4798fd86e21577c8664e8PatKind: store constants as valtrees2025-08-14T07:39:39+00:00Ralf Jungpost@ralfj.de2025-07-28T14:59:06+00:00urn:sha1:3f1e99dca47b2cfc33906f1f1334fbed3a9fc4ceclean up witness printing for tuple-like constructors2025-08-10T23:34:11+00:00diannediannes.gm@gmail.com2025-08-10T22:52:41+00:00urn:sha1:8f649a7e585f03e69c61a5b8286a61b38307afe8
By construction, `subpatterns` contains all fields in order. Witness
patterns are constructed with all fields in order by
`WitnessPat::wild_from_ctor` and `WitnessStack::apply_constructor`, and
the order is preserved at `write_struct_like`'s call-site in
`print_witness_pat`. It's thus no longer necessary to go looking for
fields or handle missing fields.
show a trailing comma on singleton tuple constructors in witness pats2025-08-10T22:32:14+00:00diannediannes.gm@gmail.com2025-08-10T22:32:14+00:00urn:sha1:9449b786218d5c5b66222a774f445e1ccf3e3666In rustc_pattern_analysis, put `true` witnesses before `false` witnesses2025-07-27T23:01:39+00:00Chayim Refael Friedmanchayimfr@gmail.com2025-07-27T21:01:28+00:00urn:sha1:6bf3cbe39e09f4d9187a0b1f6a7bd45101f7aad8
In rustc it doesn't really matter what the order of the witnesses is, but I'm planning to use the witnesses for implementing the "add missing match arms" assist in rust-analyzer, and there `true` before `false` is the natural order (like `Some` before `None`), and also what the current assist does.
The current order doesn't seem to be intentional; the code was created when bool ctors became their own thing, not just int ctors, but for integer, 0 before 1 is indeed the natural order.