rust/compiler/rustc_pattern_analysis, branch lcnr/rustc-dev-guidehttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=lcnr/rustc-dev-guide2025-08-08T19:22:44+00:00Rollup merge of #144545 - ChayimFriedman2:bool-witness-order, r=Nadrieril2025-08-08T19:22:44+00:00Trevor Grosst.gross35@gmail.com2025-08-08T19:22:44+00:00urn:sha1:18abf3aa44c53652c017752eda43f0405cd22c13
In rustc_pattern_analysis, put `true` witnesses before `false` witnesses
In rustc it doesn't really matter what the order of the witnesses is, but I'm planning to use the witnesses for implementing the "add missing match arms" assist in rust-analyzer, and there `true` before `false` is the natural order (like `Some` before `None`), and also what the current assist does.
The current order doesn't seem to be intentional; the code was created when bool ctors became their own thing, not just int ctors, but for integer, 0 before 1 is indeed the natural order.
r? `@Nadrieril`
Tidy up `Cargo.toml` files.2025-07-31T09:58:04+00:00Nicholas Nethercoten.nethercote@gmail.com2025-07-31T03:15:49+00:00urn:sha1:704f2ca17224dc1d208423c675313521b0f49645
- Add some missing `tidy-alphabetical-*` markers.
- Remove some unnecessary blank lines.
In rustc_pattern_analysis, put `true` witnesses before `false` witnesses2025-07-27T23:01:39+00:00Chayim Refael Friedmanchayimfr@gmail.com2025-07-27T21:01:28+00:00urn:sha1:6bf3cbe39e09f4d9187a0b1f6a7bd45101f7aad8
In rustc it doesn't really matter what the order of the witnesses is, but I'm planning to use the witnesses for implementing the "add missing match arms" assist in rust-analyzer, and there `true` before `false` is the natural order (like `Some` before `None`), and also what the current assist does.
The current order doesn't seem to be intentional; the code was created when bool ctors became their own thing, not just int ctors, but for integer, 0 before 1 is indeed the natural order.
Rollup merge of #144171 - Nadrieril:exhaustive-witnesses, r=davidtwco2025-07-26T06:15:04+00:00Trevor Grosst.gross35@gmail.com2025-07-26T06:15:04+00:00urn:sha1:3f7d497c8aba1b415c2b9b6a597eab1faa744416
pattern_analysis: add option to get a full set of witnesses
This adds an option to the rustc_pattern_analysis machinery to have it report a complete set of patterns when a match is non-exhaustive (by default we only guarantee to report _some_ missing patterns). This is for use in rust-analyzer.
Leaving as draft until I'm sure this is what r-a needs.
r? ghost
Silence a warning2025-07-20T16:27:30+00:00Nadrierilnadrieril+git@gmail.com2025-07-19T20:14:12+00:00urn:sha1:af07c08c60fe779c2e73c561403cb5edf4f15e9bList all the variants of non-exhaustive enums in exhaustive mode2025-07-20T16:27:30+00:00Nadrierilnadrieril+git@gmail.com2025-07-19T19:18:14+00:00urn:sha1:9b01de20e10376d379ae32baa6a315d8e30cb351pattern_analysis: add option to get a full set of witnesses2025-07-20T16:27:30+00:00Nadrierilnadrieril+git@gmail.com2025-07-19T09:28:31+00:00urn:sha1:2bb00741d463143a10e632bb118d4ed336dbb75fDon't consider unstable fields always-inhabited2025-07-20T16:23:18+00:00Nadrierilnadrieril+git@gmail.com2025-07-20T12:28:58+00:00urn:sha1:3567ab19a0edb4f6c7ca88157d84caa3e1564326
This reverts the hack in https://github.com/rust-lang/rust/pull/133889
now that `Pin`'s field is no longer public.
only check for mixed deref/normal constructors when needed2025-07-05T06:47:31+00:00diannediannes.gm@gmail.com2025-07-05T04:53:03+00:00urn:sha1:bb643159786c789c0b64f819d36a0979c63f9791always check for mixed deref pattern and normal constructors2025-07-05T06:47:31+00:00diannediannes.gm@gmail.com2025-07-05T04:17:40+00:00urn:sha1:50061f3b11f51d7a6e3acd8ce793a1f17f99b597
This makes it work for box patterns and in rust-analyzer.