rust/compiler/rustc_query_impl/src/values.rs, branch tryhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try2022-09-07T00:26:08+00:00Make `HandleCycleError` an enum instead of a macro-generated closure2022-09-07T00:26:08+00:00Joshua Nelsonjnelson@cloudflare.com2022-09-02T01:43:12+00:00urn:sha1:4856affd90df68b0b56dee73c431e9d9cdfc977a
- Add a `HandleCycleError` enum to rustc_query_system, along with a `handle_cycle_error` function
- Move `Value` to rustc_query_system, so `handle_cycle_error` can use it
- Move the `Value` impls from rustc_query_impl to rustc_middle. This is necessary due to orphan rules.
Do not report cycle error when inferring return type for suggestion2022-08-16T03:00:32+00:00Michael Gouletmichael@errs.io2022-08-10T20:53:06+00:00urn:sha1:5309375d2c8d51dafedb5404f0fb49f402350394Overhaul `TyS` and `Ty`.2022-02-15T05:03:24+00:00Nicholas Nethercoten.nethercote@gmail.com2022-01-25T03:13:38+00:00urn:sha1:e9a0c429c5da5a34c0469117774fe32694a0281c
Specifically, change `Ty` from this:
```
pub type Ty<'tcx> = &'tcx TyS<'tcx>;
```
to this
```
pub struct Ty<'tcx>(Interned<'tcx, TyS<'tcx>>);
```
There are two benefits to this.
- It's now a first class type, so we can define methods on it. This
means we can move a lot of methods away from `TyS`, leaving `TyS` as a
barely-used type, which is appropriate given that it's not meant to
be used directly.
- The uniqueness requirement is now explicit, via the `Interned` type.
E.g. the pointer-based `Eq` and `Hash` comes from `Interned`, rather
than via `TyS`, which wasn't obvious at all.
Much of this commit is boring churn. The interesting changes are in
these files:
- compiler/rustc_middle/src/arena.rs
- compiler/rustc_middle/src/mir/visit.rs
- compiler/rustc_middle/src/ty/context.rs
- compiler/rustc_middle/src/ty/mod.rs
Specifically:
- Most mentions of `TyS` are removed. It's very much a dumb struct now;
`Ty` has all the smarts.
- `TyS` now has `crate` visibility instead of `pub`.
- `TyS::make_for_test` is removed in favour of the static `BOOL_TY`,
which just works better with the new structure.
- The `Eq`/`Ord`/`Hash` impls are removed from `TyS`. `Interned`s impls
of `Eq`/`Hash` now suffice. `Ord` is now partly on `Interned`
(pointer-based, for the `Equal` case) and partly on `TyS`
(contents-based, for the other cases).
- There are many tedious sigil adjustments, i.e. adding or removing `*`
or `&`. They seem to be unavoidable.
Move the query system to rustc_query_impl.2021-02-19T16:51:58+00:00Camille GILLOTgillot.camille@gmail.com2021-01-19T19:40:16+00:00urn:sha1:4581d16bcbea9273b6755dd24a884a234a0dc2f7