rust/compiler/rustc_resolve/src/diagnostics.rs, branch 1.69.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.69.02023-02-27T16:22:51+00:00diagnostics: avoid querying `associated_item` in the resolver2023-02-27T16:22:51+00:00Michael Howellmichael@notriddle.com2023-02-27T15:48:50+00:00urn:sha1:f058bb0fcfeef3ebb0da19b2399f575c3aa9c3e8
Fixes #108529
Auto merge of #108324 - notriddle:notriddle/assoc-fn-method, r=compiler-errors,davidtwco,estebank,oli-obk2023-02-23T00:19:12+00:00borsbors@rust-lang.org2023-02-23T00:19:12+00:00urn:sha1:0978711950b77582e4f8f334f6e9848d48ab7790
diagnostics: if AssocFn has self argument, describe as method
Discussed in https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.22associated.20function.22.20vs.20.22method.22/near/329265515
This commit also changes the tooltips on rustdoc intra-doc links targeting methods.
For anyone not sure why this is being done, see the Reference definitions of these terms in <https://doc.rust-lang.org/1.67.1/reference/items/associated-items.html#methods>
> Associated functions whose first parameter is named `self` are called methods and may be invoked using the [method call operator](https://doc.rust-lang.org/1.67.1/reference/expressions/method-call-expr.html), for example, `x.foo()`, as well as the usual function call notation.
In particular, while this means it's technically correct for rustc to refer to a method as an associated function (and there are a few cases where it'll still do so), rustc *must never* use the term "method" to refer to an associated function that does not have a `self` parameter.
resolve: Remove `ImportResolver`2023-02-22T17:29:38+00:00Vadim Petrochenkovvadim.petrochenkov@gmail.com2023-02-22T17:20:54+00:00urn:sha1:d275114bda57e272b7a0a439d6b0a668bf988dd5
It's a trivial wrapper over `Resolver` that doesn't bring any benefits
diagnostics: if AssocFn has self argument, describe as method2023-02-22T15:40:33+00:00Michael Howellmichael@notriddle.com2023-02-21T21:05:32+00:00urn:sha1:3d056c31257cc26760b7e65c5dfdae069f7ddc74
Discussed in
https://rust-lang.zulipchat.com/#narrow/stream/147480-t-compiler.2Fwg-diagnostics/topic/.22associated.20function.22.20vs.20.22method.22/near/329265515
This commit also changes the tooltips on rustdoc intra-doc links
targeting methods.
Use `source_span` query instead of passing the untracked vec around2023-02-21T08:29:55+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2023-02-21T08:29:55+00:00urn:sha1:a04e78730e501de7147ba8c09372348529b00c17Auto merge of #105462 - oli-obk:feeding_full, r=cjgillot,petrochenkov2023-02-21T01:19:25+00:00borsbors@rust-lang.org2023-02-21T01:19:25+00:00urn:sha1:2deff71719a32af76eb4493ddb1dc4653fb88cad
give the resolver access to TyCtxt
The resolver is now created after TyCtxt is created. Then macro expansion and name resolution are run and the results fed into queries just like before this PR.
Since the resolver had (before this PR) mutable access to the `CStore` and the source span table, these two datastructures are now behind a `RwLock`. To ensure that these are not mutated anymore after the resolver is done, a read lock to them is leaked right after the resolver finishes.
### PRs split out of this one and leading up to it:
* https://github.com/rust-lang/rust/pull/105423
* https://github.com/rust-lang/rust/pull/105357
* https://github.com/rust-lang/rust/pull/105603
* https://github.com/rust-lang/rust/pull/106776
* https://github.com/rust-lang/rust/pull/106810
* https://github.com/rust-lang/rust/pull/106812
* https://github.com/rust-lang/rust/pull/108032
Stuff a TyCtxt into the Resolver2023-02-20T15:28:59+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2022-12-09T22:53:31+00:00urn:sha1:4953d70e2fb5f023682cbc7c9e4aa0c5c8619664Make untracked.source_span lockable so that resolution can still write to it when using TyCtxt2023-02-20T15:28:58+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2022-12-08T11:02:47+00:00urn:sha1:6924e3c374563217a724f7ffca1a5087166e8f49Prepare crate loader for LockGuard2023-02-20T10:49:42+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2022-12-08T10:43:21+00:00urn:sha1:e8e227aec84ea8b19751d9dd851a10937a70810aPrepare for adding a `TyCtxt` to `Resolver`2023-02-20T10:38:48+00:00Oli Scherergit-spam-no-reply9815368754983@oli-obk.de2023-02-20T10:38:48+00:00urn:sha1:d191de63f00f667b35f7b3a917985e0fc2ddd1cd