rust/compiler/rustc_resolve/src/diagnostics.rs, branch 1.71.0

Use `Option::is_some_and` and `Result::is_ok_and` in the compiler

2023-05-24T14:20:41+00:00

Rollup merge of #111652 - clubby789:self-import-improvement, r=compiler-errors

2023-05-20T06:51:00+00:00

Better diagnostic for `use Self::..` Fixes #111627 cc `@petrochenkov,` you might have thoughts on a better way to handle this (https://github.com/rust-lang/rust/issues/63720#issuecomment-591597466)

fix(resolve): only disambiguate binding key during define

2023-05-18T01:29:48+00:00

Better diagnostic for `use Self::..`

2023-05-16T20:30:48+00:00

Revert "Validate resolution for SelfCtor too."

2023-05-14T12:48:32+00:00

This reverts commit 83453408a0ce91b9e3d3ae6e7f117b1fd28b487d.

Improve error for `self: Box`

2023-05-11T12:21:10+00:00

improve diagnostics and bless tests

2023-05-05T20:42:54+00:00

Rollup merge of #111020 - cjgillot:validate-self-ctor, r=petrochenkov

2023-05-04T06:09:04+00:00

Validate resolution for SelfCtor too. Fixes https://github.com/rust-lang/rust/issues/89868 r? `@petrochenkov`

Validate resolution for SelfCtor too.

2023-05-03T17:55:27+00:00

Restrict `From` for `{D,Subd}iagnosticMessage`.

2023-05-02T22:44:39+00:00
Currently a `{D,Subd}iagnosticMessage` can be created from any type that impls `Into`. That includes `&str`, `String`, and `Cow<'static, str>`, which are reasonable. It also includes `&String`, which is pretty weird, and results in many places making unnecessary allocations for patterns like this: ``` self.fatal(&format!(...)) ``` This creates a string with `format!`, takes a reference, passes the reference to `fatal`, which does an `into()`, which clones the reference, doing a second allocation. Two allocations for a single string, bleh. This commit changes the `From` impls so that you can only create a `{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static, str>`. This requires changing all the places that currently create one from a `&String`. Most of these are of the `&format!(...)` form described above; each one removes an unnecessary static `&`, plus an allocation when executed. There are also a few places where the existing use of `&String` was more reasonable; these now just use `clone()` at the call site. As well as making the code nicer and more efficient, this is a step towards possibly using `Cow<'static, str>` in `{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing the `From<&'a str>` impls to `From<&'static str>`, which is doable, but I'm not yet sure if it's worthwhile.