https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=beta 2025-09-07T06:18:59+00:00 2025-09-07T06:18:59+00:00 Matthias Krüger 476013+matthiaskrgr@users.noreply.github.com 2025-09-07T06:18:59+00:00 urn:sha1:cb8b5fa4e2a68460ffbf7a733cd2851fa13ba6a9 Use `Itertools::all_equal_value()` where applicable Just a small cleanup. We already have `itertools` as a dep in these crates, so might as well use another of its features. Makes the code simpler IMHO :) 2025-09-05T18:43:43+00:00 Yotam Ofek yotam.ofek@gmail.com 2025-09-05T18:43:43+00:00 urn:sha1:f279ae1b05fe0f12259b3e24d35f5598b18f5ea9 2025-09-05T13:38:01+00:00 Matthias Krüger matthias.krueger@famsik.de 2025-09-05T13:38:01+00:00 urn:sha1:81042523c6e1ae50682f46ae3da4ede22bfd596e 2025-09-05T05:50:24+00:00 bors bors@rust-lang.org 2025-09-05T05:50:24+00:00 urn:sha1:ad85bc524b1ad696e42061ad8338d382dffbdbe5 resolve: Avoid finalizing extern prelude entries more than once 2025-09-04T00:01:54+00:00 Stuart Cook Zalathar@users.noreply.github.com 2025-09-04T00:01:54+00:00 urn:sha1:3a6ae1167f56516fc0de1d304fcb9163cea0cb40 On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const When encountering an or-pattern with a binding not available in all patterns, look for consts and unit struct/variants that have similar names as the binding to detect typos. ``` error[E0408]: variable `Ban` is not bound in all patterns --> $DIR/binding-typo.rs:22:9 | LL | (Foo, _) | (Ban, Foo) => {} | ^^^^^^^^ --- variable not in all patterns | | | pattern doesn't bind `Ban` | help: you might have meant to use the similarly named unit variant `Bar` | LL - (Foo, _) | (Ban, Foo) => {} LL + (Foo, _) | (Bar, Foo) => {} | ``` For items that are not in the immedate scope, suggest the full path for them: ``` error[E0408]: variable `Non` is not bound in all patterns --> $DIR/binding-typo-2.rs:51:16 | LL | (Non | Some(_))=> {} | --- ^^^^^^^ pattern doesn't bind `Non` | | | variable not in all patterns | help: you might have meant to use the similarly named unit variant `None` | LL - (Non | Some(_))=> {} LL + (core::option::Option::None | Some(_))=> {} | ``` When encountering a typo in a pattern that gets interpreted as an unused binding, look for unit struct/variant of the same type as the binding: ``` error: unused variable: `Non` --> $DIR/binding-typo-2.rs:36:9 | LL | Non => {} | ^^^ | help: if this is intentional, prefix it with an underscore | LL | _Non => {} | + help: you might have meant to pattern match on the similarly named variant `None` | LL - Non => {} LL + std::prelude::v1::None => {} | ``` Suggest constant on unused binding in a pattern ``` error: unused variable: `Batery` --> $DIR/binding-typo-2.rs:110:9 | LL | Batery => {} | ^^^^^^ | help: if this is intentional, prefix it with an underscore | LL | _Batery => {} | + help: you might have meant to pattern match on the similarly named constant `Battery` | LL | Battery => {} | + ``` Fix rust-lang/rust#51976. 2025-09-03T13:08:08+00:00 Stuart Cook Zalathar@users.noreply.github.com 2025-09-03T13:08:08+00:00 urn:sha1:8746c2302c5e5a1a0eb575d7400d596f10c8e922 resolve: Avoid a regression from splitting prelude into two scopes Fixes https://github.com/rust-lang/rust/issues/145575. 2025-09-02T15:08:52+00:00 Guillaume Gomez guillaume1.gomez@gmail.com 2025-09-02T15:08:52+00:00 urn:sha1:af315b0725a00e52b74fddfd709b1bb7be7bebbd add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: https://github.com/rust-lang/rust-clippy/pull/15000#discussion_r2134145163 It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer. 2025-09-02T13:22:16+00:00 Vadim Petrochenkov vadim.petrochenkov@gmail.com 2025-09-02T12:03:11+00:00 urn:sha1:235dfbab9cb4965a1d23c4d2278923c6ff8e193d 2025-09-02T09:12:54+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-09-02T09:09:13+00:00 urn:sha1:301655eafe56a4b5064adebd412becf94b59221c This was done in #145740 and #145947. It is causing problems for people using r-a on anything that uses the rustc-dev rustup package, e.g. Miri, clippy. This repository has lots of submodules and subtrees and various different projects are carved out of pieces of it. It seems like `[workspace.dependencies]` will just be more trouble than it's worth. 2025-08-30T17:44:23+00:00 Esteban Küber esteban@kuber.com.ar 2025-08-30T17:44:23+00:00 urn:sha1:86085b4f65fae0ebc456202584e7e04b58a871f3