https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.84.0 2024-11-15T09:35:33+00:00 2024-11-15T09:35:33+00:00 Piotr Osiewicz 24362066+osiewicz@users.noreply.github.com 2024-11-11T17:34:46+00:00 urn:sha1:42e71bb8ea2bf59fb33cf3f83a3dcf34e314f520 Over in Zed we've noticed that loading crates for a large-ish workspace can take almost 200ms. We've pinned it down to how rustc searches for paths, as it performs a linear search over the list of candidate paths. In our case the candidate list had about 20k entries which we had to iterate over for each dependency being loaded. This commit introduces a simple FilesIndex that's just a sorted Vec under the hood. Since crates are looked up by both prefix and suffix, we perform a range search on said Vec (which constraints the search space based on prefix) and follow up with a linear scan of entries with matching suffixes. FilesIndex is also pre-filtered before any queries are performed using available target information; query prefixes/sufixes are based on the target we are compiling for, so we can remove entries that can never match up front. Overall, this commit brings down build time for us in dev scenarios by about 6%. 100ms might not seem like much, but this is a constant cost that each of our workspace crates has to pay, even when said crate is miniscule. 2024-11-11T00:00:58+00:00 bors bors@rust-lang.org 2024-11-11T00:00:58+00:00 urn:sha1:42b24963202f31d417a972e56e48a17e916b279b Add Unicode block-drawing compiler output support Add nightly-only theming support to rustc output using Unicode box drawing characters instead of ASCII-art to draw the terminal UI. In order to enable, the flags `-Zunstable-options=yes --error-format=human-unicode` must be passed in. After: ``` error: foo ╭▸ test.rs:3:3 │ 3 │ X0 Y0 Z0 │ ┌───╿──│──┘ │ ┌│───│──┘ │ ┏││━━━┙ │ ┃││ 4 │ ┃││ X1 Y1 Z1 5 │ ┃││ X2 Y2 Z2 │ ┃│└────╿──│──┘ `Z` label │ ┃└─────│──┤ │ ┗━━━━━━┥ `Y` is a good letter too │ `X` is a good letter ╰╴ note: bar ╭▸ test.rs:4:3 │ 4 │ ┏ X1 Y1 Z1 5 │ ┃ X2 Y2 Z2 6 │ ┃ X3 Y3 Z3 │ ┗━━━━━━━━━━┛ ├ note: bar ╰ note: baz note: qux ╭▸ test.rs:4:3 │ 4 │ X1 Y1 Z1 ╰╴ ━━━━━━━━ ``` Before: ``` error: foo --> test.rs:3:3 | 3 | X0 Y0 Z0 | ___^__-__- | |___|__| | ||___| | ||| 4 | ||| X1 Y1 Z1 5 | ||| X2 Y2 Z2 | |||____^__-__- `Z` label | ||_____|__| | |______| `Y` is a good letter too | `X` is a good letter | note: bar --> test.rs:4:3 | 4 | / X1 Y1 Z1 5 | | X2 Y2 Z2 6 | | X3 Y3 Z3 | |__________^ = note: bar = note: baz note: qux --> test.rs:4:3 | 4 | X1 Y1 Z1 | ^^^^^^^^ ``` After:  Before:  2024-11-10T22:57:18+00:00 Esteban Küber esteban@kuber.com.ar 2024-06-17T15:14:07+00:00 urn:sha1:1d78004575bea3b958b199d50a8491ae3fd65679 Add nightly-only theming support to rustc output using Unicode box drawing characters instead of ASCII-art to draw the terminal UI: After: ``` error: foo ╭▸ test.rs:3:3 │ 3 │ X0 Y0 Z0 │ ┌───╿──│──┘ │ ┌│───│──┘ │ ┏││━━━┙ │ ┃││ 4 │ ┃││ X1 Y1 Z1 5 │ ┃││ X2 Y2 Z2 │ ┃│└────╿──│──┘ `Z` label │ ┃└─────│──┤ │ ┗━━━━━━┥ `Y` is a good letter too │ `X` is a good letter ╰╴ note: bar ╭▸ test.rs:4:3 │ 4 │ ┏ X1 Y1 Z1 5 │ ┃ X2 Y2 Z2 6 │ ┃ X3 Y3 Z3 │ ┗━━━━━━━━━━┛ ├ note: bar ╰ note: baz note: qux ╭▸ test.rs:4:3 │ 4 │ X1 Y1 Z1 ╰╴ ━━━━━━━━ ``` Before: ``` error: foo --> test.rs:3:3 | 3 | X0 Y0 Z0 | ___^__-__- | |___|__| | ||___| | ||| 4 | ||| X1 Y1 Z1 5 | ||| X2 Y2 Z2 | |||____^__-__- `Z` label | ||_____|__| | |______| `Y` is a good letter too | `X` is a good letter | note: bar --> test.rs:4:3 | 4 | / X1 Y1 Z1 5 | | X2 Y2 Z2 6 | | X3 Y3 Z3 | |__________^ = note: bar = note: baz note: qux --> test.rs:4:3 | 4 | X1 Y1 Z1 | ^^^^^^^^ ``` 2024-11-09T22:32:06+00:00 Ralf Jung post@ralfj.de 2024-11-09T22:32:06+00:00 urn:sha1:f235b6f9c6788e213b6365103cfa9c6c798fe659 2024-11-02T20:29:59+00:00 Noratrieb 48135649+Noratrieb@users.noreply.github.com 2024-10-17T17:02:32+00:00 urn:sha1:a26450cf81d67d68d3c6157579f8d968349129e7 This changes the naming to the new naming, used by `--print target-tuple`. It does not change all locations, but many. 2024-10-28T15:05:08+00:00 klensy klensy@users.noreply.github.com 2024-10-07T19:22:51+00:00 urn:sha1:746b675c5aabc7a61443f16a37223720657544d2 2024-10-17T17:29:31+00:00 Andrew Zhogin andrew.zhogin@gmail.com 2024-09-16T15:14:35+00:00 urn:sha1:b3ae64d24fc323365bd09fe6ac8b7438f5713078 2024-10-10T09:46:11+00:00 Mads Marquart mads@marquart.dk 2024-10-10T09:46:11+00:00 urn:sha1:1edff466e19c4e2e2f8035de5a25d8a2dc2fef96 2024-10-01T12:32:13+00:00 David Lattimore dvdlttmr@gmail.com 2024-09-30T22:55:10+00:00 urn:sha1:f48194ea5578802c786edff59dd72388da0e6305 MCP: https://github.com/rust-lang/compiler-team/issues/782 Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com> 2024-09-22T23:11:29+00:00 Michael Goulet michael@errs.io 2024-09-22T23:05:04+00:00 urn:sha1:c682aa162b0d41e21cc6748f4fecfe01efb69d1f