https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.66.1 2022-06-01T00:36:39+00:00 2022-06-01T00:36:39+00:00 Nicholas Nethercote n.nethercote@gmail.com 2022-05-30T05:59:45+00:00 urn:sha1:0b81d7cdc653f540e9fa219820928184e0273f5f `SourceFile::lines` is a big part of metadata. It's stored in a compressed form (a difference list) to save disk space. Decoding it is a big fraction of compile time for very small crates/programs. This commit introduces a new type `SourceFileLines` which has a `Lines` form and a `Diffs` form. The latter is used when the metadata is first read, and it is only decoded into the `Lines` form when line data is actually needed. This avoids the decoding cost for many files, especially in `std`. It's a performance win of up to 15% for tiny crates/programs where metadata decoding is a high part of compilation costs. A `Lock` is needed because the methods that access lines data (which can trigger decoding) take `&self` rather than `&mut self`. To allow for this, `SourceFile::lines` now takes a `FnMut` that operates on the lines slice rather than returning the lines slice. 2021-07-08T21:30:53+00:00 Tomasz Miąsko tomasz.miasko@gmail.com 2021-07-05T00:00:00+00:00 urn:sha1:1719d4501351eff05299a124dc13846afa2994a0 to simplify the implementation and avoid unnecessary conversions from `Option<usize>` to `isize` and back. 2020-08-30T15:45:07+00:00 mark markm@cs.wisc.edu 2020-08-28T03:58:48+00:00 urn:sha1:9e5f7d5631b8f4009ac1c693e585d4b7108d4275