https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.78.0 2024-03-10T23:04:49+00:00 2024-03-10T23:04:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-03-06T03:00:16+00:00 urn:sha1:541d7cc65c56402f31335e41075838c0da5fbe01 To match `derive(Subdiagnostic)`. Also rename `add_to_diagnostic{,_with}` as `add_to_diag{,_with}`. 2024-03-10T22:15:09+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-03-06T00:02:56+00:00 urn:sha1:7a294e998b66ea6d410a6840cba80347fc4764c2 To match `derive(Diagnostic)`. Also rename `into_diagnostic` as `into_diag`. 2024-03-05T01:14:49+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-29T05:18:19+00:00 urn:sha1:573267cf3c10c13f4cb3b9935affd05925d938d0 2024-02-27T21:55:35+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-22T23:20:45+00:00 urn:sha1:899cb40809a85eb9d89f6da3268713b83175360a Much better! Note that this involves renaming (and updating the value of) `DIAGNOSTIC_BUILDER` in clippy. 2024-02-20T02:22:17+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-06T05:44:30+00:00 urn:sha1:f6f87798439e2ce7861da761b444fe0978335ed9 Currently many diagnostic modifier methods are available on both `Diagnostic` and `DiagnosticBuilder`. This commit removes most of them from `Diagnostic`. To minimize the diff size, it keeps them within `diagnostic.rs` but changes the surrounding `impl Diagnostic` block to `impl DiagnosticBuilder`. (I intend to move things around later, to give a more sensible code layout.) `Diagnostic` keeps a few methods that it still needs, like `sub`, `arg`, and `replace_args`. The `forward!` macro, which defined two additional methods per call (e.g. `note` and `with_note`), is replaced by the `with_fn!` macro, which defines one additional method per call (e.g. `with_note`). It's now also only used when necessary -- not all modifier methods currently need a `with_*` form. (New ones can be easily added as necessary.) All this also requires changing `trait AddToDiagnostic` so its methods take `DiagnosticBuilder` instead of `Diagnostic`, which leads to many mechanical changes. `SubdiagnosticMessageOp` gains a type parameter `G`. There are three subdiagnostics -- `DelayedAtWithoutNewline`, `DelayedAtWithNewline`, and `InvalidFlushedDelayedDiagnosticLevel` -- that are created within the diagnostics machinery and appended to external diagnostics. These are handled at the `Diagnostic` level, which means it's now hard to construct them via `derive(Diagnostic)`, so instead we construct them by hand. This has no effect on what they look like when printed. There are lots of new `allow` markers for `untranslatable_diagnostics` and `diagnostics_outside_of_impl`. This is because `#[rustc_lint_diagnostics]` annotations were present on the `Diagnostic` modifier methods, but missing from the `DiagnosticBuilder` modifier methods. They're now present. 2024-02-15T15:59:35+00:00 Michael Goulet michael@errs.io 2024-02-14T23:52:57+00:00 urn:sha1:acb201af54e15b1beebb5b8a6691f6c851afe177 2024-02-08T02:02:44+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-02-06T05:35:19+00:00 urn:sha1:6b175a848d72f0ea60d80de3bd74d0806a64c40f It avoids a lot of repetition. 2024-01-28T20:41:41+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-13T23:57:07+00:00 urn:sha1:5d9dfbd08f38c2a9bc71d39de8f5c7776afe0f9e Error codes are integers, but `String` is used everywhere to represent them. Gross! This commit introduces `ErrCode`, an integral newtype for error codes, replacing `String`. It also introduces a constant for every error code, e.g. `E0123`, and removes the `error_code!` macro. The constants are imported wherever used with `use rustc_errors::codes::*`. With the old code, we have three different ways to specify an error code at a use point: ``` error_code!(E0123) // macro call struct_span_code_err!(dcx, span, E0123, "msg"); // bare ident arg to macro call \#[diag(name, code = "E0123")] // string struct Diag; ``` With the new code, they all use the `E0123` constant. ``` E0123 // constant struct_span_code_err!(dcx, span, E0123, "msg"); // constant \#[diag(name, code = E0123)] // constant struct Diag; ``` The commit also changes the structure of the error code definitions: - `rustc_error_codes` now just defines a higher-order macro listing the used error codes and nothing else. - Because that's now the only thing in the `rustc_error_codes` crate, I moved it into the `lib.rs` file and removed the `error_codes.rs` file. - `rustc_errors` uses that macro to define everything, e.g. the error code constants and the `DIAGNOSTIC_TABLES`. This is in its new `codes.rs` file. 2024-01-03T08:40:20+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-23T22:08:41+00:00 urn:sha1:505c1371d070ba6c9e15db7d331f2d6a2b167b68 `Diagnostic` has 40 methods that return `&mut Self` and could be considered setters. Four of them have a `set_` prefix. This doesn't seem necessary for a type that implements the builder pattern. This commit removes the `set_` prefixes on those four methods. 2023-12-18T22:19:25+00:00 Nicholas Nethercote n.nethercote@gmail.com 2023-12-18T03:12:39+00:00 urn:sha1:e7724a2e319f112ee6a97999976d8225b009456e And make all hand-written `IntoDiagnostic` impls generic, by using `DiagnosticBuilder::new(dcx, level, ...)` instead of e.g. `dcx.struct_err(...)`. This means the `create_*` functions are the source of the error level. This change will let us remove `struct_diagnostic`. Note: `#[rustc_lint_diagnostics]` is added to `DiagnosticBuilder::new`, it's necessary to pass diagnostics tests now that it's used in `into_diagnostic` functions.