rust/compiler/rustc_trait_selection/src, branch 1.84.1

add cache to `AmbiguityCausesVisitor`

2025-01-23T19:48:40+00:00

(cherry picked from commit 94bf8f04f402a2410ab85a6e6b9e542e3942b2a2)

avoid running the overlap check twice

2025-01-23T19:48:40+00:00

(cherry picked from commit ebbcfd4e7721aaf3211f0e8d3d6e304400c80f78)

Make sure to record deps from cached task in new solver on first run

2025-01-23T19:46:15+00:00

(cherry picked from commit 988f28d442d2e959897e43a239f67d42e0297990)

Revert "Remove less relevant info from diagnostic"

2025-01-23T19:32:32+00:00

This reverts commit 8a568d9f15453cbfe5d6f45fa5f5bb32e58b93ed. (cherry picked from commit 764e3e264f69d8af9fa42d86ea36702584dcb36b)

Do not call `extern_crate` on current trait on crate mismatch errors

2025-01-02T21:43:18+00:00

When we encounter an error caused by traits/types of different versions of the same crate, filter out the current crate when collecting spans to add to the context so we don't call `extern_crate` on the `DefId` of the current crate, which is meaningless and ICEs. Produced output with this filter: ``` error[E0277]: the trait bound `foo::Struct: Trait` is not satisfied --> y.rs:13:19 | 13 | check_trait::(); | ^^^^^^^^^^^ the trait `Trait` is not implemented for `foo::Struct` | note: there are multiple different versions of crate `foo` in the dependency graph --> y.rs:7:1 | 4 | extern crate foo; | ----------------- one version of crate `foo` is used here, as a direct dependency of the current crate 5 | 6 | pub struct Struct; | ----------------- this type implements the required trait 7 | pub trait Trait {} | ^^^^^^^^^^^^^^^ this is the required trait | ::: x.rs:4:1 | 4 | pub struct Struct; | ----------------- this type doesn't implement the required trait 5 | pub trait Trait {} | --------------- this is the found trait = note: two types coming from two different versions of the same crate are different types even if they look the same = help: you can use `cargo tree` to explore your dependency tree note: required by a bound in `check_trait` --> y.rs:10:19 | 10 | fn check_trait() {} | ^^^^^ required by this bound in `check_trait` ``` Fix #133563. (cherry picked from commit 8574f374e2cc27b53c8b81dc4031c59ca3035284)

Rollup merge of #132489 - compiler-errors:fn-sugg-tweaks, r=BoxyUwU

2024-11-21T10:58:39+00:00

Fix closure arg extraction in `extract_callable_info`, generalize it to async closures * Fix argument extraction in `extract_callable_info` * FIx `extract_callable_info` to work for async closures * Remove redundant `is_fn_ty` which is just a less general `extract_callable_info` * More precisely name what is being called (i.e. call it a "closure" not a "function") Review this without whitespace -- I ended up reformatting `extract_callable_info` because some pesky `//` comments were keeping the let-chains from being formatted.

Rip out built-in PointerLike impl

2024-11-20T16:13:57+00:00

additional `TypingEnv` cleanups

2024-11-19T20:36:23+00:00

rustdoc: yeet `TypingEnv::from_param_env`

2024-11-19T17:35:41+00:00

move `fn is_item_raw` to `TypingEnv`

2024-11-19T17:06:20+00:00