https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.66.1 2022-10-07T14:33:46+00:00 2022-10-07T14:33:46+00:00 Cameron Steffen cam.steffen94@gmail.com 2022-08-15T19:11:11+00:00 urn:sha1:ff940db666daeae83c6c71685901c6c14df17018 2022-10-06T14:29:43+00:00 Matthias Krüger matthias.krueger@famsik.de 2022-10-06T14:29:43+00:00 urn:sha1:dd0fa6f871cfbf0d206cd66846bb754cae5c60d3 make `compare_const_impl` a query and use it in `instance.rs` Fixes #88365 the bug in #88365 was caused by some `instance.rs` code using the `PartialEq` impl on `Ty` to check that the type of the associated const in an impl is the same as the type of the associated const in the trait definition. This was wrong for two reasons: - the check typeck does is that the impl type is a subtype of the trait definition's type (see `mismatched_impl_ty_2.rs` which [was ICEing](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f6d60ebe6745011f0d52ab2bc712025d) before this PR on stable) - it assumes that if two types are equal then the `PartialEq` impl will reflect that which isnt true for higher ranked types or type level constants when `feature(generic_const_exprs)` is enabled (see `mismatched_impl_ty_3.rs` for higher ranked types which was [ICEing on stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=d7af131a655ed515b035624626c62c71)) r? `@lcnr` 2022-10-03T14:12:03+00:00 Cameron Steffen cam.steffen94@gmail.com 2022-10-03T00:06:14+00:00 urn:sha1:95b689b1d55936cb9d51bb01672f28f1e05994c4 2022-09-30T17:53:32+00:00 Boxy supbscripter@gmail.com 2022-09-30T17:53:32+00:00 urn:sha1:c1a9cf42b400bab235d2d1c11d35270879d8fd60 2022-09-26T08:14:45+00:00 Pietro Albini pietro.albini@ferrous-systems.com 2022-09-20T13:41:42+00:00 urn:sha1:3975d55d9888392cd738708b914442de9ac2bff5 2022-09-15T19:06:45+00:00 est31 MTest31@outlook.com 2022-02-27T06:07:36+00:00 urn:sha1:173eb6f407438dff732b1636b5134ff220da3f5b On later stages, the feature is already stable. Result of running: rg -l "feature.let_else" compiler/ src/librustdoc/ library/ | xargs sed -s -i "s#\\[feature.let_else#\\[cfg_attr\\(bootstrap, feature\\(let_else\\)#" 2022-08-26T13:36:51+00:00 Peter Medus 16763503+Facel3ss1@users.noreply.github.com 2022-08-18T23:04:31+00:00 urn:sha1:01c1616b2568a712dfa3e4dc6af233f5152ff362 2022-08-17T10:22:32+00:00 lcnr rust@lcnr.de 2022-08-17T10:22:32+00:00 urn:sha1:4fe666ee64d9f2a73571f0ab74a29cd30190573e 2022-07-12T02:21:31+00:00 kadmin julianknodt@gmail.com 2022-07-09T09:35:06+00:00 urn:sha1:e612e2603cfffedfc000853648bc061a4aa7269c 2022-06-28T20:45:05+00:00 Dominik Stolz d.stolz@tum.de 2022-06-28T20:45:05+00:00 urn:sha1:080525229b9830c727cf447236deb7bdae7d5814