rust/compiler/rustc_ty_utils/src/needs_drop.rs, branch 1.73.0

Don't require `Drop` for `[PhantomData; N]` where `N` and `T` are generic, if `T` requires `Drop`

2023-09-16T21:54:55+00:00

Use upvar_tys in more places, make it a list

2023-08-01T23:19:31+00:00

inline format!() args from rustc_codegen_llvm to the end (4)

2023-07-25T21:20:28+00:00

r? @WaffleLapkin

some additional refactor

2023-07-18T13:50:34+00:00

also, treat placeholders equal to params

exhaustive matches are good

2023-07-17T13:12:21+00:00

refactor(rustc_middle): Substs -> GenericArg

2023-07-14T12:27:35+00:00

EarlyBinder::new -> EarlyBinder::bind

2023-05-29T11:46:10+00:00

Replace EarlyBinder(x) with EarlyBinder::new(x)

2023-05-28T16:44:50+00:00

Move expansion of query macros in rustc_middle to rustc_middle::query

2023-05-15T06:49:13+00:00

Restrict `From` for `{D,Subd}iagnosticMessage`.

2023-05-02T22:44:39+00:00
Currently a `{D,Subd}iagnosticMessage` can be created from any type that impls `Into`. That includes `&str`, `String`, and `Cow<'static, str>`, which are reasonable. It also includes `&String`, which is pretty weird, and results in many places making unnecessary allocations for patterns like this: ``` self.fatal(&format!(...)) ``` This creates a string with `format!`, takes a reference, passes the reference to `fatal`, which does an `into()`, which clones the reference, doing a second allocation. Two allocations for a single string, bleh. This commit changes the `From` impls so that you can only create a `{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static, str>`. This requires changing all the places that currently create one from a `&String`. Most of these are of the `&format!(...)` form described above; each one removes an unnecessary static `&`, plus an allocation when executed. There are also a few places where the existing use of `&String` was more reasonable; these now just use `clone()` at the call site. As well as making the code nicer and more efficient, this is a step towards possibly using `Cow<'static, str>` in `{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing the `From<&'a str>` impls to `From<&'static str>`, which is doable, but I'm not yet sure if it's worthwhile.