rust/library/alloc/src/collections/binary_heap.rs, branch 1.58.0

provide a `SpecExtend` trait for `Vec`

2021-11-12T07:45:25+00:00

The discussion is [here](https://internals.rust-lang.org/t/append-vec-to-binaryheap/15209/3)

Rollup merge of #89786 - jkugelman:must-use-len-and-is_empty, r=joshtriplett

2021-10-31T12:20:05+00:00

Add #[must_use] to len and is_empty Parent issue: #89692 r? `@joshtriplett`

Add #[must_use] to len and is_empty

2021-10-30T23:25:12+00:00

Rollup merge of #89899 - jkugelman:must-use-alloc, r=joshtriplett

2021-10-30T22:33:24+00:00

Add #[must_use] to remaining alloc functions I've run out of compelling reasons to group functions together across crates so I'm just going to go module-by-module. This is everything remaining from the `alloc` crate. I ignored these because they might be used to purposefully leak memory... or other allocator shenanigans? I dunno. I'll add them if y'all tell me to. ```rust alloc::alloc unsafe fn alloc(layout: Layout) -> *mut u8; alloc::alloc unsafe fn alloc_zeroed(layout: Layout) -> *mut u8; alloc::sync::Arc fn into_raw(this: Self) -> *const T; ``` I don't know why clippy ignored these. I added them myself: ```rust alloc::collections::btree_map::BTreeMap fn range(&self, range: R) -> Range<'_, K, V>; alloc::collections::btree_set::BTreeSet fn range(&self, range: R) -> Range<'_, T>; ``` I added these non-mutating `mut` functions: ```rust alloc::collections::btree_map::BTreeMap fn range_mut(&mut self, range: R) -> RangeMut<'_, K, V>; alloc::collections::btree_map::BTreeMap fn iter_mut(&mut self) -> IterMut<'_, K, V>; alloc::collections::btree_map::BTreeMap fn values_mut(&mut self) -> ValuesMut<'_, K, V>; alloc::collections::linked_list::LinkedList fn iter_mut(&mut self) -> IterMut<'_, T>; alloc::collections::linked_list::LinkedList fn cursor_front_mut(&mut self) -> CursorMut<'_, T>; alloc::collections::linked_list::LinkedList fn cursor_back_mut(&mut self) -> CursorMut<'_, T>; alloc::collections::linked_list::LinkedList fn front_mut(&mut self) -> Option<&mut T>; alloc::collections::linked_list::LinkedList fn back_mut(&mut self) -> Option<&mut T>; alloc::collections::linked_list::CursorMut<'a, T> fn current(&mut self) -> Option<&mut T>; alloc::collections::linked_list::CursorMut<'a, T> fn peek_next(&mut self) -> Option<&mut T>; alloc::collections::linked_list::CursorMut<'a, T> fn peek_prev(&mut self) -> Option<&mut T>; alloc::collections::linked_list::CursorMut<'a, T> fn front_mut(&mut self) -> Option<&mut T>; alloc::collections::linked_list::CursorMut<'a, T> fn back_mut(&mut self) -> Option<&mut T>; ``` I moved a few existing `#[must_use]`s from functions onto the iterator types they return: `IntoIterSorted`, `IntoKeys`, `IntoValues`. Parent issue: #89692 r? `@joshtriplett`

Clarify undefined behaviour for binary heap, btree and hashset

2021-10-21T13:30:46+00:00

Previously, it wasn't clear whether "This could include" was referring to logic errors, or undefined behaviour. Tweak wording to clarify this sentence does not relate to UB.

Add #[must_use] to remaining alloc functions

2021-10-15T15:46:49+00:00

Rollup merge of #89778 - jkugelman:must-use-as_type-conversions, r=joshtriplett

2021-10-12T12:53:08+00:00

Add #[must_use] to as_type conversions Clippy missed these: ```rust alloc::string::String fn as_mut_str(&mut self) -> &mut str; core::mem::NonNull unsafe fn as_uninit_mut<'a>(&mut self) -> &'a MaybeUninit; str unsafe fn as_bytes_mut(&mut self) -> &mut [u8]; str fn as_mut_ptr(&mut self) -> *mut u8; ``` Parent issue: #89692 r? ````@joshtriplett````

Add #[must_use] to as_type conversions

2021-10-11T17:57:38+00:00

Rollup merge of #89726 - jkugelman:must-use-alloc-constructors, r=joshtriplett

2021-10-11T12:11:42+00:00

Add #[must_use] to alloc constructors Added `#[must_use]`. to the various forms of `new`, `pin`, and `with_capacity` in the `alloc` crate. No extra explanations given as I couldn't think of anything useful to add. I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular: * The 4 `pin`/`pin_in` methods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with. * `Box`'s constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory? Parent issue: #89692 r? ``@joshtriplett``

Add #[must_use] to conversions that move self

2021-10-10T23:50:52+00:00