rust/library/alloc/src/collections/btree/set.rs, branch try https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try 2025-06-27T18:12:32+00:00 BTreeSet: remove duplicated code by reusing `from_sorted_iter` 2025-06-27T18:12:32+00:00 Cheng Xu git@xuc.me 2025-06-27T18:01:59+00:00 urn:sha1:cd1713ebba83a87e80a7366fdfe6fc28cabe6053 The method `BTreeSet::from_sorted_iter` was introduced in 49ccb7519f55bd117d2ab50b7a030637f380aec6, but it was not consistently used throughout the codebase. As a result, some code redundantly reimplemented its logic. This commit fixes the problem. Remove unneeded lifetimes from signature of BTreeSet::extract_if 2025-06-14T03:33:54+00:00 David Tolnay dtolnay@gmail.com 2025-06-14T03:04:49+00:00 urn:sha1:dac9d78647f2a1483710e2417d817c7df04eba8d Lightly tweak docs for BTree{Map,Set}::extract_if 2025-06-02T17:10:00+00:00 Sidney Cammeresi sac@readyset.io 2025-06-02T16:43:48+00:00 urn:sha1:a20cf473e7b888f9ef7995971f0c5613a81e68ff - Move explanations into comments to match style - Explain the second examples - Make variable names match the data structure Update docs for new Range parameter to `BTreeMap::extract_if` etc. 2025-05-27T15:31:56+00:00 Sidney Cammeresi sac@readyset.io 2025-05-08T00:06:53+00:00 urn:sha1:38c37eb3cbd87894cdab588b5002fa07803feff7 Add Range parameter to `BTreeMap::extract_if` and `BTreeSet::extract_if` 2025-05-27T15:31:40+00:00 Sidney Cammeresi sac@readyset.io 2025-05-08T00:00:09+00:00 urn:sha1:51d247c2cfbd3aea896c650e5cf25eb0a8e14615 This change was requested in the btree_extract_if tracking issue: https://github.com/rust-lang/rust/issues/70530#issuecomment-2486566328 Consistent trait bounds for ExtractIf Debug impls 2025-05-06T02:46:46+00:00 David Tolnay dtolnay@gmail.com 2025-03-15T18:19:56+00:00 urn:sha1:c35914383a92d7504f3a71c390dc2ebd14bce695 Remove some unnecessary clones. 2025-04-24T01:12:34+00:00 Nicholas Nethercote n.nethercote@gmail.com 2025-04-23T22:49:49+00:00 urn:sha1:055a27da2afcc8a7d74a551c32e8a831a825d549 I found these by grepping for `&[a-z_\.]*\.clone()`, i.e. expressions like `&a.b.clone()`, which are sometimes unnecessary clones, and also looking at clones nearby to cases like that. Remove erroneous `unsafe` in `BTreeSet::upper_bound_mut` 2025-01-22T15:36:33+00:00 Pavel Grigorenko GrigorenkoPV@ya.ru 2025-01-22T15:36:33+00:00 urn:sha1:bae2a2f3b56b4540bf21e2aab888a945f38e1fe3 Specify only that duplicates are discarded, not the order. 2024-12-22T16:16:54+00:00 Kevin Reid kpreid@switchb.org 2024-12-22T16:13:00+00:00 urn:sha1:6a43716ada10c18d6991dd9408ce2f31214cb8f3 Document collection `From` and `FromIterator` impls that drop duplicate keys. 2024-12-22T03:57:42+00:00 Kevin Reid kpreid@google.com 2021-10-13T15:46:34+00:00 urn:sha1:b5e8a5d3939935eecfe8ed2dbc97ad748e090d90 This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first.