rust/library/alloc/src/vec, branch masterhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=master2025-09-28T03:23:45+00:00Auto merge of #147042 - Noratrieb:untrack-caller-vec, r=tgross352025-09-28T03:23:45+00:00borsbors@rust-lang.org2025-09-28T03:23:45+00:00urn:sha1:c7f6aa2869acdbf014d094c6e427e554e160b6db
Remove most `#[track_caller]` from allocating Vec methods
They cause significant binary size overhead while contributing little value.
closes rust-lang/rust#146963, see that issue for more details.
Remove most `#[track_caller]` from allocating Vec methods2025-09-25T18:52:03+00:00Noratrieb48135649+Noratrieb@users.noreply.github.com2025-09-25T18:36:58+00:00urn:sha1:9316d4508c42d5e6d91480aec34f66462801ee5d
They cause significant binary size overhead while contributing little
value.
Also removes them from the wrapping String methods that do not panic.
Rollup merge of #146293 - BenjaminBrienen:try_remove, r=joboet2025-09-25T16:15:09+00:00Matthias Krüger476013+matthiaskrgr@users.noreply.github.com2025-09-25T16:15:09+00:00urn:sha1:fea9196e5271a61dc526246a6ccdc2db0f998603
feat: non-panicking `Vec::try_remove`
`if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful.
APC: https://github.com/rust-lang/libs-team/issues/649
Tracking issue: https://github.com/rust-lang/rust/issues/146954
Rollup merge of #141032 - petrosagg:extract-if-ub, r=joboet2025-09-25T16:15:07+00:00Matthias Krüger476013+matthiaskrgr@users.noreply.github.com2025-09-25T16:15:07+00:00urn:sha1:e3f762673241c2892951be3477b99753b68e41e1
avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`
The implementation of the `Vec::extract_if` iterator violates the safety contract adverized by `slice::from_raw_parts` by always constructing a mutable slice for the entire length of the vector even though that span of memory can contain holes from items already drained. The safety contract of `slice::from_raw_parts` requires that all elements must be properly
initialized.
As an example we can look at the following code:
```rust
let mut v = vec![Box::new(0u64), Box::new(1u64)];
for item in v.extract_if(.., |x| **x == 0) {
drop(item);
}
```
In the second iteration a `&mut [Box<u64>]` slice of length 2 will be constructed. The first slot of the slice contains the bitpattern of an already deallocated box, which is invalid.
This fixes the issue by only creating references to valid items and using pointer manipulation for the rest. I have also taken the liberty to remove the big `unsafe` blocks in place of targetted ones with a SAFETY comment. The approach closely mirrors the implementation of `Vec::retain_mut`.
**Note to reviewers:** The diff is easier to follow with whitespace hidden.
feature: Implement vec_try_remove2025-09-24T13:29:09+00:00BenjaminBrienenBenjamin.Brienen@outlook.com2025-09-24T12:25:10+00:00urn:sha1:56734495e2fd485a7be1ba77da1bf18a0eca4636
Vec::try_remove is a non-panicking version of Vec::remove
avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`2025-09-22T07:59:52+00:00Petros Angelatospetrosagg@gmail.com2025-05-15T12:46:53+00:00urn:sha1:e9b2c4f395673399b0445733c7e8d3955e42ff0c
The implementation of the `Vec::extract_if` iterator violates the safety
contract adverized by `slice::from_raw_parts` by always constructing a
mutable slice for the entire length of the vector even though that span
of memory can contain holes from items already drained. The safety
contract of `slice::from_raw_parts` requires that all elements must be
properly initialized.
As an example we can look at the following code:
```rust
let mut v = vec![Box::new(0u64), Box::new(1u64)];
for item in v.extract_if(.., |x| **x == 0) {
drop(item);
}
```
In the second iteration a `&mut [Box<u64>]` slice of length 2 will be
constructed. The first slot of the slice contains the bitpattern of an
already deallocated box, which is invalid.
This fixes the issue by only creating references to valid items and
using pointer manipulation for the rest. I have also taken the liberty
to remove the big `unsafe` blocks in place of targetted ones with a
SAFETY comment. The approach closely mirrors the implementation of
`Vec::retain_mut`.
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
Change the cfg to a dash2025-09-21T17:12:20+00:00Ben Kimockkimockb@gmail.com2025-09-18T14:48:18+00:00urn:sha1:df58fd8cf7710f7516c541769a141f0235978dabAdd panic=immediate-abort2025-09-21T17:12:18+00:00Ben Kimockkimockb@gmail.com2025-09-07T16:31:35+00:00urn:sha1:888679013d1f424adef06267f3630069b4cabd40docs: improve doc of some methods w/ ranges2025-09-20T10:17:56+00:00tk49250442+tkr-sh@users.noreply.github.com2025-05-13T22:54:47+00:00urn:sha1:ac3c480388d27ee9ebeb23d308bd37289d37bc41Plumb Allocator generic into `std::vec::PeekMut`2025-09-19T00:29:23+00:00Sidney Cammeresisac@cheesecake.org2025-09-14T18:14:50+00:00urn:sha1:934ee043feb6601f9dfb5be173a190a921e6d9a9