https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.52.1 2021-03-14T04:07:28+00:00 2021-03-14T04:07:28+00:00 Yuki Okushi huyuumi.dev@gmail.com 2021-03-14T04:07:28+00:00 urn:sha1:67bc866e5934e19c37fd7a115cdc8142fcb8c51d Implement Extend and FromIterator for OsString Add the following trait impls: - `impl Extend<OsString> for OsString` - `impl<'a> Extend<&'a OsStr> for OsString` - `impl FromIterator<OsString> for OsString` - `impl<'a> FromIterator<&'a OsStr> for OsString` Because `OsString` is a platform string with no particular semantics, concatenating them together seems acceptable. I came across a use case for these trait impls in https://github.com/artichoke/artichoke/pull/1089: Artichoke is a Ruby interpreter. Its CLI accepts multiple `-e` switches for executing inline Ruby code, like: ```console $ cargo -q run --bin artichoke -- -e '2.times {' -e 'puts "foo: #{__LINE__}"' -e '}' foo: 2 foo: 2 ``` I use `clap` for command line argument parsing, which collects these `-e` commands into a `Vec<OsString>`. To pass these commands to the interpreter for `Eval`, I need to join them together. Combining these impls with `Iterator::intersperse` https://github.com/rust-lang/rust/issues/79524 would enable me to build a single bit of Ruby code. Currently, I'm doing something like: ```rust let mut commands = commands.into_iter(); let mut buf = if let Some(command) = commands.next() { command } else { return Ok(Ok(())); }; for command in commands { buf.push("\n"); buf.push(command); } ``` If there's interest, I'd also like to add impls for `Cow<'a, OsStr>`, which would avoid allocating the `"\n"` `OsString` in the concatenate + intersperse use case. 2021-03-03T19:52:14+00:00 Ryan Lopopolo rjl@hyperbo.la 2021-03-03T19:52:14+00:00 urn:sha1:05ea200213fe30967fff38ebac887c52803aabd5 2021-02-26T01:31:53+00:00 Joshua Nelson jyn514@gmail.com 2020-12-19T13:23:59+00:00 urn:sha1:9a75f4fed10a65e6cb779fc059f272deadd7ecc1 2021-02-23T01:51:51+00:00 Dylan DPC dylan.dpc@gmail.com 2021-02-23T01:51:51+00:00 urn:sha1:b8d4354099a070fa34bdf373e0f2ae2e40797ee9 add diagnostic items for OsString/PathBuf/Owned as well as to_vec on slice This is adding diagnostic items to be used by rust-lang/rust-clippy#6730, but my understanding is the clippy-side change does need to be done over there since I am adding a new clippy feature. Add diagnostic items to the following types: OsString (os_string_type) PathBuf (path_buf_type) Owned (to_owned_trait) As well as the to_vec method on slice/[T] 2021-02-16T22:20:26+00:00 Ryan Lopopolo rjl@hyperbo.la 2021-02-16T22:14:59+00:00 urn:sha1:2fcb8b5c201d22060f1ba46cc2291cacca593e02 2021-02-16T02:32:21+00:00 Andrea Nall anall@andreanall.com 2021-02-16T02:32:21+00:00 urn:sha1:67fcaaaa7a9c393926e25db600a9976137425d68 2021-02-15T22:59:47+00:00 Andrea Nall anall@andreanall.com 2021-02-15T22:58:03+00:00 urn:sha1:c6bb62810ae226b35e0181d8c4efc6d0377d196d 2021-02-15T02:27:28+00:00 Andrea Nall anall@andreanall.com 2021-02-15T02:27:20+00:00 urn:sha1:5ef202520f9c4c87dd6218bbfbbf57587e88f8be Add diagnostic items to the following types: OsString (os_string_type) PathBuf (path_buf_type) Owned (to_owned_trait) As well as the to_vec method on slice/[T] 2021-02-14T23:01:46+00:00 Ryan Lopopolo rjl@hyperbo.la 2021-02-14T23:01:46+00:00 urn:sha1:3ed618443437307749e4c773f260c2b4b94673f5 Add the following trait impls: - `impl Extend<OsString> for OsString` - `impl<'a> Extend<&'a OsStr> for OsString` - `impl FromIterator<OsString> for OsString` - `impl<'a> FromIterator<&'a OsStr> for OsString` Because `OsString` is a platform string with no particular semantics, concatenating them together seems acceptable. 2021-02-10T21:30:30+00:00 Amanieu d'Antras amanieu@gmail.com 2021-02-10T21:30:30+00:00 urn:sha1:bfd1ccfb271f03aa85488408c3b03a15ad8d7c7f