rust/library/std/src/sys/windows/process.rs, branch tryhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try2024-01-11T19:10:25+00:00std: begin moving platform support modules into `pal`2024-01-11T19:10:25+00:00joboetjonasboettiger@icloud.com2024-01-11T19:10:25+00:00urn:sha1:99128b7e45f8b95d962da2e6ea584767f0c85455Rollup merge of #118060 - ChrisDenton:abs-device-path, r=thomcc2023-11-24T07:23:53+00:00Matthias Krügermatthias.krueger@famsik.de2023-11-24T07:23:53+00:00urn:sha1:b2d6480f536196b8075d5fd451a70fca8f04a3f5
Use an absolute path to the NUL device
While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly.
This will also set a good example for people copying std code.
r? libs
x fmt library/std2023-11-22T13:17:02+00:00Chris Dentonchris@chrisdenton.dev2023-11-22T00:44:37+00:00urn:sha1:b9fe367b9993c33a022411fd08e3da0081abacfdredundant_closure2023-11-22T13:00:29+00:00Chris Dentonchris@chrisdenton.dev2023-11-21T23:45:52+00:00urn:sha1:220217af135198ed950133f9785d93df1d49097cunnecessary_cast2023-11-22T13:00:29+00:00Chris Dentonchris@chrisdenton.dev2023-11-21T23:40:46+00:00urn:sha1:9e42456a0defc5839b505edfa5ec7f9d7aa3644f
casting to the same type is unnecessary
needless_borrows_for_generic_args2023-11-22T13:00:28+00:00Chris Dentonchris@chrisdenton.dev2023-11-21T23:21:56+00:00urn:sha1:42734599bd613efee41d0a508e0fc60ea6d86058
the borrowed expression implements the required traits
Use an absolute path to the NUL device2023-11-19T16:24:39+00:00Chris Dentonchris@chrisdenton.dev2023-11-19T16:24:39+00:00urn:sha1:3a486c1feb0a4846a3bcff0dda5182dc9c762ba2
While a bare "NUL" *should* be redirected to the NUL device, especially in this simple case, let's be explicit that we aren't opening a file called "NUL" and instead open it directly.
This will also set a good example for people copying std code.
Remove libc2023-10-05T23:35:00+00:00Chris Dentonchris@chrisdenton.dev2023-10-05T23:35:00+00:00urn:sha1:c8f3aa451a0b50051980cf22d5ca35d7f515b43b
We don't use much libc on Windows.
Auto merge of #114590 - ijackson:stdio-stdio-2, r=dtolnay2023-09-09T19:56:51+00:00borsbors@rust-lang.org2023-09-09T19:56:51+00:00urn:sha1:559421e8e3ab373a296186104b7b0c18251e8182
Allow redirecting subprocess stdout to our stderr etc. (redux)
This is the code from #88561, tidied up, including review suggestions, and with the for-testing-only CI commit removed. FCP for the API completed in #88561.
I have made a new MR to facilitate review. The discussion there is very cluttered and the branch is full of changes (in many cases as a result of changes to other Rust stdlib APIs since then). Assuming this MR is approvedl we should close that one.
### Reviewer doing a de novo review
Just code review these four commits.. FCP discussion starts here: https://github.com/rust-lang/rust/pull/88561#issuecomment-1640527595
Portability tests: you can see that this branch works on Windows too by looking at the CI results in #88561, which has the same code changes as this branch but with an additional "DO NOT MERGE" commit to make the Windows tests run.
### Reviewer doing an incremental review from some version of #88561
Review the new commits since your last review. I haven't force pushed the branch there.
git diff the two branches (eg `git diff 176886197d6..0842b69c219`). You'll see that the only difference is in gitlab CI files. You can also see that *this* MR doesn't touch those files.
Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of2023-09-03T15:04:42+00:00Fulgen301Fulgen301@users.noreply.github.com2023-09-03T15:04:42+00:00urn:sha1:a8b0e44e86c944350b2064f5c0f297346bf0c32c