https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=master 2024-06-15T15:47:35+00:00 2024-06-15T15:47:35+00:00 joboet jonasboettiger@icloud.com 2024-06-15T15:47:35+00:00 urn:sha1:f3facf11758af878bcfaf47fc773962dbb565024 As discovered by Mara in #110897, our TLS implementation is a total mess. In the past months, I have simplified the actual macros and their expansions, but the majority of the complexity comes from the platform-specific support code needed to create keys and register destructors. In keeping with #117276, I have therefore moved all of the `thread_local_key`/`thread_local_dtor` modules to the `thread_local` module in `sys` and merged them into a new structure, so that future porters of `std` can simply mix-and-match the existing code instead of having to copy the same (bad) implementation everywhere. The new structure should become obvious when looking at `sys/thread_local/mod.rs`. Unfortunately, the documentation changes associated with the refactoring have made this PR rather large. That said, this contains no functional changes except for two small ones: * the key-based destructor fallback now, by virtue of sharing the implementation used by macOS and others, stores its list in a `#[thread_local]` static instead of in the key, eliminating one indirection layer and drastically simplifying its code. * I've switched over ZKVM (tier 3) to use the same implementation as WebAssembly, as the implementation was just a way worse version of that Please let me know if I can make this easier to review! I know these large PRs aren't optimal, but I couldn't think of any good intermediate steps. @rustbot label +A-thread-locals 2024-02-21T19:15:52+00:00 Ralf Jung post@ralfj.de 2024-02-11T18:04:29+00:00 urn:sha1:b58f647d5488dce73bba517907c44af2c2a618c4 also introduce ptr::dangling matching NonNull::dangling 2023-04-27T13:25:48+00:00 Mara Bos m-ou.se@m-ou.se 2023-04-27T13:25:00+00:00 urn:sha1:0b3073abb1b4f783deaf3860fe745c586ae2bded 2022-08-11T13:39:25+00:00 Ralf Jung post@ralfj.de 2022-08-11T13:39:25+00:00 urn:sha1:b5786dcae6c5a300f146fcbf6dab509d2cd48ec8 2020-08-31T02:56:59+00:00 Lzu Tao taolzu@gmail.com 2020-08-27T13:45:01+00:00 urn:sha1:a4e926daeeaedc9178846711daf1f4cb6ce505fb Also doing fmt inplace as requested.