https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.25.0 2018-01-07T01:15:59+00:00 2018-01-07T01:15:59+00:00 Zack M. Davis code@zackmdavis.net 2017-11-19T19:25:35+00:00 urn:sha1:aba56ddd05d821b6f0a3e5fc05bc47311e09051c Previously, on a type mismatch (and if this wasn't preëmpted by a higher-priority suggestion), we would look for argumentless methods returning the expected type, and list them in a `help` note. This had two major shortcomings. Firstly, a lot of the suggestions didn't really make sense (if you used a &str where a String was expected, `.to_ascii_uppercase()` is probably not the solution you were hoping for). Secondly, we weren't generating suggestions from the most useful traits! We address the first problem with an internal `#[rustc_conversion_suggestion]` attribute meant to mark methods that keep the "same value" in the relevant sense, just converting the type. We address the second problem by making `FnCtxt.probe_for_return_type` pass the `ProbeScope::AllTraits` to `probe_op`: this would seem to be safe because grep reveals no other callers of `probe_for_return_type`. Also, structured suggestions are preferred (because they're pretty, but also for RLS and friends). Also also, we make the E0055 autoderef recursion limit error use the one-time-diagnostics set, because we can potentially hit the limit a lot during probing. (Without this, test/ui/did_you_mean/recursion_limit_deref.rs would report "aborting due to 51 errors"). Unfortunately, the trait probing is still not all one would hope for: at a minimum, we don't know how to rule out `into()` in cases where it wouldn't actually work, and we don't know how to rule in `.to_owned()` where it would. Issues #46459 and #46460 have been filed and are ref'd in a FIXME. This is hoped to resolve #42929, #44672, and #45777. 2017-12-09T22:18:33+00:00 Matt Brubeck mbrubeck@limpet.net 2017-12-09T01:32:04+00:00 urn:sha1:3024c1434a667425d30e4b0785857381323712aa 2017-11-21T14:33:45+00:00 Martin Lindhe martin-commit@ubique.se 2017-11-21T14:33:45+00:00 urn:sha1:ece9a57d1b6e10ef2ad1dffd19fd6033cdc760ee 2017-11-03T20:27:40+00:00 Lukas Kalbertodt lukas.kalbertodt@gmail.com 2017-10-02T07:50:36+00:00 urn:sha1:da57580736c6d30fec6c4e4442bc5376ac81f245 Many AsciiExt imports have become useless thanks to the inherent ascii methods added in the last commits. These were removed. In some places, I fully specified the ascii method being called to enforce usage of the AsciiExt trait. Note that some imports are not removed but tagged with a `#[cfg(stage0)]` attribute. This is necessary, because certain ascii methods are not yet available in stage0. All those imports will be removed later. Additionally, failing tests were fixed. The test suite should exit successfully now. 2017-09-17T08:41:24+00:00 Michal Budzynski budziq@gmail.com 2017-09-17T08:41:24+00:00 urn:sha1:6b167f98d9dcfef79519d79d03930062215158fc 2017-09-15T02:32:52+00:00 Corey Farwell coreyf@rwell.org 2017-09-15T02:32:52+00:00 urn:sha1:68e0f28304249a4f2db6b177b3be156ba4774a92 Clarify return type of `String::from_utf16_lossy`. Fixes https://github.com/rust-lang/rust/issues/32874 2017-09-15T02:32:38+00:00 Corey Farwell coreyf@rwell.org 2017-09-15T02:32:38+00:00 urn:sha1:b4f6fba1d9b3acddc8c63e7ccdf857cfc0032aa2 Add doc example to String::as_mut_str Fixes #44429. 2017-09-14T19:47:37+00:00 Corey Farwell coreyf@rwell.org 2017-09-14T19:34:31+00:00 urn:sha1:258ef37f8e81388a11f420411e35b427215b0754 Fixes https://github.com/rust-lang/rust/issues/32874 2017-09-10T13:11:27+00:00 Tommy Ip hkmp7tommy@gmail.com 2017-09-09T12:08:26+00:00 urn:sha1:bc1a4c635703e08f0ee5830b389b2b804e82d76b Fixes #44429. 2017-09-09T08:05:54+00:00 Tommy Ip hkmp7tommy@gmail.com 2017-09-09T08:05:54+00:00 urn:sha1:3e8fadc2ac5d5e25aaf0449d50988c54be92dbe4 Fixes #44428.