Add Arc::{incr,decr}_strong_count

2020-05-07T15:18:25+00:00

Fix link in task::Wake docs

2020-04-03T09:33:27+00:00

Apply suggestions from code review

2020-03-23T14:45:30+00:00

Co-Authored-By: Ashley Mannix

Update src/liballoc/task.rs

2020-03-23T14:45:30+00:00

Co-Authored-By: Ashley Mannix

More explicit; CFG on atomic pointer

2020-03-23T14:45:30+00:00

Improve safety implementation, fix typos

2020-03-23T14:45:30+00:00

Add Wake trait for safe construction of Wakers.

2020-03-23T14:44:58+00:00

Currently, constructing a waker requires calling the unsafe `Waker::from_raw` API. This API requires the user to manually construct a vtable for the waker themself - which is both cumbersome and very error prone. This API would provide an ergonomic, straightforward and guaranteed memory-safe way of constructing a waker. It has been our longstanding intention that the `Waker` type essentially function as an `Arc`, with a `Wake` trait as defined here. Two considerations prevented the original API from being shipped as simply an `Arc`: - We want to support futures on embedded systems, which may not have an allocator, and in optimized executors for which this API may not be best-suited. Therefore, we have always explicitly supported the maximally-flexible (but also memory-unsafe) `RawWaker` API, and `Waker` has always lived in libcore. - Because `Waker` lives in libcore and `Arc` lives in liballoc, it has not been feasible to provide a constructor for `Waker` from `Arc`. Therefore, the Wake trait was left out of the initial version of the task waker API. However, as Rust 1.41, it is possible under the more flexible orphan rules to implement `From> for Waker where W: Wake` in liballoc. Therefore, we can now define this constructor even though `Waker` lives in libcore. This PR adds these APIs: - A `Wake` trait, which contains two methods - A required method `wake`, which is called by `Waker::wake` - A provided method `wake_by_ref`, which is called by `Waker::wake_by_ref` and which implementors can override if they can optimize this use case. - An implementation of `From> for Waker where W: Wake + Send + Sync + 'static` - A similar implementation of `From> for RawWaker`.

Update the future/task API

2019-02-03T21:46:53+00:00

This change updates the future and task API as discussed in the stabilization RFC at https://github.com/rust-lang/rfcs/pull/2592. Changes: - Replacing UnsafeWake with RawWaker and RawWakerVtable - Removal of LocalWaker - Removal of Arc-based Wake trait

liballoc: revert nested imports style changes.

2019-02-03T07:27:44+00:00

rust/src/liballoc/task.rs, branch 1.45.0

Add Arc::{incr,decr}_strong_count

Fix link in task::Wake docs

Apply suggestions from code review

Update src/liballoc/task.rs

More explicit; CFG on atomic pointer

typo

Improve safety implementation, fix typos

Add Wake trait for safe construction of Wakers.

Update the future/task API

liballoc: revert nested imports style changes.