https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.37.0 2019-06-10T10:42:43+00:00 2019-06-10T10:42:43+00:00 Ralf Jung post@ralfj.de 2019-06-10T10:42:43+00:00 urn:sha1:7b97cf94315983bc032e92209b6f00a518262460 2019-06-09T00:28:29+00:00 Napen123 napen123@gmail.com 2019-06-09T00:28:29+00:00 urn:sha1:1b6b7597ed96815d9944f8c77eaffb18daece20c 2019-05-22T21:09:34+00:00 Steven Fackler sfackler@palantir.com 2019-05-22T21:09:34+00:00 urn:sha1:8a22bc3b30e81568db25cf57aa9e7629bfa449c7 This reverts commit 3e86cf36b5114f201868bf459934fe346a76a2d4. 2019-05-14T20:00:11+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-05-14T20:00:11+00:00 urn:sha1:088c99410b8516a4fc639507ab6c27184875d005 as_ptr returns a read-only pointer Add comments to `as_ptr` methods to warn that these are read-only pointers, and writing to them is UB. [It was pointed out](https://internals.rust-lang.org/t/as-ptr-vs-as-mut-ptr/9940) that `CStr` does not even have an `as_mut_ptr`. I originally was going to add one, but there is no method at all that would mutate a `CStr`. Was that a deliberate choice or should I add an `as_mut_ptr` (similar to [what I did for `str`](https://github.com/rust-lang/rust/pull/58200))? 2019-05-14T20:00:09+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-05-14T20:00:09+00:00 urn:sha1:bab03cecfeadcbc79ee2aead61c4de973e5649a0 Add implementations of last in terms of next_back on a bunch of DoubleEndedIterators Provided a `DoubleEndedIterator` has finite length, `Iterator::last` is equivalent to `DoubleEndedIterator::next_back`. But searching forwards through the iterator when it's unnecessary is obviously not good for performance. I ran into this on one of the collection iterators. I tried adding appropriate overloads for a bunch of the iterator adapters like filter, map, etc, but I ran into a lot of type inference failures after doing so. The other interesting case is what to do with `Repeat`. Do we consider it part of the contract that `Iterator::last` will loop forever on it? The docs do say that the iterator will be evaluated until it returns None. This is also relevant for the adapters, it's trivially easy to observe whether a `Map` adapter invoked its closure a zillion times or just once for the last element. 2019-05-02T11:36:30+00:00 Ralf Jung post@ralfj.de 2019-05-02T11:36:30+00:00 urn:sha1:30cf0e4251533e67603c755acee5b0bd56197fce 2019-05-01T15:59:48+00:00 Ralf Jung post@ralfj.de 2019-05-01T15:59:48+00:00 urn:sha1:1e47250540bc97f921d1b7e2982f1904fa191dff 2019-04-29T20:22:42+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-04-29T20:22:42+00:00 urn:sha1:c9b70144a365656b2f16a983bda57b66e978c058 Stabilize str::as_mut_ptr Closes #58215 2019-04-29T20:22:34+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-04-29T20:22:34+00:00 urn:sha1:eb3c53071a8e403ea98292f99f520439473ed409 Fix equivalent string in escape_default docs This newline should be escaped. 2019-04-28T17:33:50+00:00 Yuki OKUSHI huyuumi.dev@gmail.com 2019-04-28T17:33:50+00:00 urn:sha1:4c0f01cc27a8ba8f86c7356f36bd94e437d32a39