rust/src/librustc_errors/styled_buffer.rs, branch 1.45.2 https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.45.2 2019-12-22T22:42:47+00:00 Format the world 2019-12-22T22:42:47+00:00 Mark Rousskov mark.simulacrum@gmail.com 2019-12-22T22:42:04+00:00 urn:sha1:a06baa56b95674fc626b3c3fd680d6a65357fe60 Correctly estimate required space for string 2019-10-05T00:08:05+00:00 AnthonyMikh anthony.mikh@yandex.ru 2019-10-05T00:08:05+00:00 urn:sha1:4414068cc49803b0dacba133b7788b8b95b0b473 `.len()` returns length in bytes so it overestimates the required space librustc_errors => 2018 2019-02-06T18:53:01+00:00 Taiki Endo te316e89@gmail.com 2019-02-06T18:53:01+00:00 urn:sha1:950fe6686da1fdbaf25341cc5fafe1bb9fb1b180 Remove licenses 2018-12-26T04:08:33+00:00 Mark Rousskov mark.simulacrum@gmail.com 2018-12-25T15:56:47+00:00 urn:sha1:2a663555ddf36f6b041445894a8c175cd1bc718c Highlight code on diagnostics when underlined 2018-01-29T01:15:15+00:00 Esteban Küber esteban@kuber.com.ar 2017-10-02T22:28:52+00:00 urn:sha1:871856e8312e7248d12f06f0faa1555f38e50a93 Display `\t` in diagnostics code as four spaces 2017-11-24T16:24:31+00:00 Esteban Küber esteban@kuber.com.ar 2017-11-13T06:06:00+00:00 urn:sha1:9d80e2200af22bb4532a7cc4738b22e408072ffd Fix mispositioned error indicators 2017-09-07T08:26:27+00:00 est31 MTest31@outlook.com 2017-09-07T06:47:13+00:00 urn:sha1:d58281097a3bf14fe1b199c8ba6aee00793e111e Fixes #38384 Most of the Rust community uses 4 spaces for indentation, but there are also tab users of Rust (including myself!). This patch fixes a bug in error printing which mispositions error indicators when near code with tabs. The code attempted to fix the issue by replacing spaces with tabs, but it sadly wasn't enough, as sometimes you may not print spaces but _ or ^ instead. This patch employs the reverse strategy: it replaces each tab with a space, so that the number of _ and ^ and spaces in error indicators below the code snippet line up perfectly. In a study [1] preceeding this patch, we could see that this strategy is also chosen by gcc version 6.3.0. Its not perfect, as the output is not beautiful, but its the easiest to implement. If anyone wants to improve on this, be my guest! This patch is meant as improvement of the status quo, not as perfect end status. It fixes the actual issue of mispositioning error indicators. [1]: https://github.com/rust-lang/rust/issues/38384#issuecomment-326813710 Remove unused code from librustc_errors 2017-07-07T01:49:32+00:00 Kevin Mehall km@kevinmehall.net 2017-07-02T20:46:38+00:00 urn:sha1:17bd76a5169df158a750fdf63cf35b3fbd33c28e run rustfmt on librustc_errors folder 2016-10-18T17:43:02+00:00 Srinivas Reddy Thatiparthy thatiparthysreenivas@gmail.com 2016-10-18T17:43:02+00:00 urn:sha1:b2606173450b7842a59b23f8167eb6832d9c3305 Add fix for tabs. Move error unit tests->ui tests 2016-07-14T11:57:46+00:00 Jonathan Turner jturner@mozilla.com 2016-07-13T21:53:42+00:00 urn:sha1:1fd014a9654e11ae1bc7c0793c6b01b157d825cd