rust/src/librustc_metadata/decoder.rs, branch 1.30.1https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.30.12018-10-02T12:17:47+00:00Use full name to identify a macro in a `FileName`.2018-10-02T12:17:47+00:00Diogo Sousadiogogsousa@gmail.com2018-09-19T00:09:36+00:00urn:sha1:334c2e44e4095bf56f666b353a546a16f33b38e1
Before this two macros with same name would be indistinguishable inside a
`FileName`. This caused a bug in incremental compilation (see #53097) since
two different macros would map out to the same `StableFilemapId`.
Fixes #53097.
avoid leaking host details in proc macro metadata decoding2018-09-22T17:13:45+00:00Ariel Ben-Yehudaariel.byd@gmail.com2018-09-15T20:26:04+00:00urn:sha1:002581f6278957d3d0f35483749488ff3b6a9558
proc macro crates are essentially implemented as dynamic libraries using
a dlopen-based ABI. They are also Rust crates, so they have 2 worlds -
the "host" world in which they are defined, and the "target" world in
which they are used.
For all the "target" world knows, the proc macro crate might not even
be implemented in Rust, so leaks of details from the host to the target
must be avoided for correctness.
Because the "host" DefId space is different from the "target" DefId
space, any leak involving a DefId will have a nonsensical or
out-of-bounds DefKey, and will cause all sorts of crashes.
This PR fixes all leaks I have found in `decoder`. In particular, #54059
was caused by host native libraries leaking into the target, which feels
like it might even be a correctness issue if it doesn't cause an ICE.
Fixes #54059
Auto merge of #53721 - arielb1:exhaustively-unpun, r=nikomatsakis2018-09-06T06:42:19+00:00borsbors@rust-lang.org2018-09-06T06:42:19+00:00urn:sha1:20ca02569ae3e1dc29962e92739fbab632abf241
fix `is_non_exhaustive` confusion between structs and enums
Structs and enums can both be non-exhaustive, with a very different
meaning. This PR splits `is_non_exhaustive` to 2 separate functions - 1
for structs, and another for enums, and fixes the places that got the
usage confused.
Fixes #53549.
r? @eddyb
move the is_field_list_non_exhaustive flag to VariantDef2018-09-01T16:10:26+00:00Ariel Ben-Yehudaariel.byd@gmail.com2018-09-01T16:10:26+00:00urn:sha1:ae2ad30bf1f3f924ed9ef977b3d2782f85fe2593
This completely splits the IS_NON_EXHAUSTIVE flag. No functional
changes intended.
create a valid DefIdTable for proc macro crates2018-08-26T15:48:41+00:00Ariel Ben-Yehudaariel.byd@gmail.com2018-08-25T22:53:48+00:00urn:sha1:5415bb6e8f689393b2f87dc0875bb4048f5f3067
At least the incremental compilation code, and a few other places in the
compiler, require the CrateMetadata for a loaded target crate to contain a
valid DefIdTable for the DefIds in the target.
Previously, the CrateMetadata for a proc macro contained the crate's
"host" DefIdTable, which is of course incompatible with the "target"
DefIdTable, causing ICEs. This creates a DefIdTable that properly refers
to the "proc macro" DefIds.
Fixes #49482.
Replace TyForeign with ForeignTy2018-08-22T15:08:49+00:00varkorgithub@varkor.com2018-08-22T10:47:31+00:00urn:sha1:d0209c44a620fa63d2e95d0752ef24f8f0d73cebRename Def::{Param, Foreign} to Def::{TyParam, TyForeign}2018-08-22T15:08:49+00:00varkorgithub@varkor.com2018-08-22T01:13:31+00:00urn:sha1:05cfb3f5b553f96f299919e19be10bccb240a6a7Remove Ty prefix from Ty{Foreign|Param}2018-08-22T15:07:55+00:00varkorgithub@varkor.com2018-08-22T00:35:29+00:00urn:sha1:04fa5d3adbb8212f5b4e87e3bbd7b74bb7c9ec65fix tidy errors2018-08-19T21:01:01+00:00Donato Sciarrasciarp@gmail.com2018-08-18T10:14:31+00:00urn:sha1:6138c82803a77a44e0a56cd8999299fa7f214afemv codemap source_map2018-08-19T21:01:01+00:00Donato Sciarrasciarp@gmail.com2018-08-18T10:14:14+00:00urn:sha1:062bfbf39bef9360e1553f293f4f1015c5680dec