rust/src/librustc_resolve/error_reporting.rs, branch 1.34.2 https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.34.2 2019-02-22T13:58:02+00:00 Rollup merge of #58555 - scottmcm:try-2015, r=Centril 2019-02-22T13:58:02+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-02-22T13:58:02+00:00 urn:sha1:bcb7dce75c7b566f091b9f2d5486d7aa162337de Add a note about 2018e if someone uses `try {` in 2015e Inspired by https://github.com/rust-lang/rust/issues/58491, where a `try_blocks` example was accidentally run in 2015, which of course produces a bunch of errors. What's the philosophy about gating for this? The keyword is stably a keyword in 2018, so I haven't gated it for now but am not mentioning what the keyword _does_. Let me know if I should do differently. Resolves #53672 Add a note about 2018e if someone uses `try {` in 2015e 2019-02-18T07:55:45+00:00 Scott McMurray scottmcm@users.noreply.github.com 2019-02-18T07:55:45+00:00 urn:sha1:9312ca10b6cd672c4fa1da4b4a3cc232f7d7dde6 Rollup merge of #58381 - davidtwco:issue-42944, r=estebank 2019-02-13T17:12:35+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-02-13T17:12:35+00:00 urn:sha1:8a4f8e6adcfdb5289f35a9f1049089e4dba1efb6 Only suggest imports if not imported. Fixes #42944 and fixes #53430. This commit modifies name resolution error reporting so that if a name is in scope and has been imported then we do not suggest importing it. This can occur when we add a label about constructors not being visible due to private fields. In these cases, we know that the struct/variant has been imported and we should silence any suggestions to import the struct/variant. r? @estebank Fix rebase fail 2019-02-12T15:31:53+00:00 Taiki Endo te316e89@gmail.com 2019-02-10T06:27:59+00:00 urn:sha1:c08b5ca4ad26250f6af17ba7e2938d9e694f2842 Only suggest imports if not imported. 2019-02-11T18:29:10+00:00 David Wood david@davidtw.co 2019-02-11T18:29:10+00:00 urn:sha1:48b0c9da69965cd40d037cee42cf3093ed09c6ee This commit modifies name resolution error reporting so that if a name is in scope and has been imported then we do not suggest importing it. This can occur when we add a label about constructors not being visible due to private fields. In these cases, we know that the struct/variant has been imported and we should silence any suggestions to import the struct/variant. WIP 2019-02-07T21:28:16+00:00 Alexander Regueiro alexreg@me.com 2019-02-07T21:25:15+00:00 urn:sha1:fd70e8e8db6f0a43f9f5bc669e03ab9bbdce7fbc Minor cosmetic changes. 2019-02-07T21:28:16+00:00 Alexander Regueiro alexreg@me.com 2019-02-04T10:24:09+00:00 urn:sha1:5c87bc85e2d7395d671311a5b8b97013b2e73d87 Addressed review points. 2019-02-07T21:28:16+00:00 Alexander Regueiro alexreg@me.com 2019-02-04T10:25:29+00:00 urn:sha1:497a772d04731d9e93abb71ae99696684e514bb3 librustc_resolve => 2018 2019-02-06T17:15:23+00:00 Taiki Endo te316e89@gmail.com 2019-02-06T17:15:23+00:00 urn:sha1:edbd8a36c8820fb8a128675859c1fa76feab2bea Remove licenses 2018-12-26T04:08:33+00:00 Mark Rousskov mark.simulacrum@gmail.com 2018-12-25T15:56:47+00:00 urn:sha1:2a663555ddf36f6b041445894a8c175cd1bc718c