rust/src/librustc_trait_selection/traits, branch master

mv compiler to compiler/

2020-08-30T15:45:07+00:00

hir: consistent use and naming of lang items

2020-08-24T11:17:51+00:00

This commit adjusts the naming of various lang items so that they are consistent and don't include prefixes containing the target or "LangItem". In addition, lang item variants are no longer exported from the `lang_items` module. Signed-off-by: David Wood

Use smaller def span for functions

2020-08-22T22:41:49+00:00

Currently, the def span of a funtion encompasses the entire function signature and body. However, this is usually unnecessarily verbose - when we are pointing at an entire function in a diagnostic, we almost always want to point at the signature. The actual contents of the body tends to be irrelevant to the diagnostic we are emitting, and just takes up additional screen space. This commit changes the `def_span` of all function items (freestanding functions, `impl`-block methods, and `trait`-block methods) to be the span of the signature. For example, the function ```rust pub fn foo(val: T) -> T { val } ``` now has a `def_span` corresponding to `pub fn foo(val: T) -> T` (everything before the opening curly brace). Trait methods without a body have a `def_span` which includes the trailing semicolon. For example: ```rust trait Foo { fn bar(); }``` the function definition `Foo::bar` has a `def_span` of `fn bar();` This makes our diagnostic output much shorter, and emphasizes information that is relevant to whatever diagnostic we are reporting. We continue to use the full span (including the body) in a few of places: * MIR building uses the full span when building source scopes. * 'Outlives suggestions' use the full span to sort the diagnostics being emitted. * The `#[rustc_on_unimplemented(enclosing_scope="in this scope")]` attribute points the entire scope body. * The 'unconditional recursion' lint uses the full span to show additional context for the recursive call. All of these cases work only with local items, so we don't need to add anything extra to crate metadata.

Don't immediately error for cycles during normalization

2020-08-20T18:29:42+00:00

rust_ast::ast => rustc_ast

2020-08-17T20:32:32+00:00

Auto merge of #75536 - estebank:e0255-suggestion, r=varkor

2020-08-16T11:16:44+00:00

Tweak output of E0225 When encountering multiple non-auto trait bounds suggest creating a new trait and explain what auto-traits are. _Inspired by https://fasterthanli.me/articles/frustrated-its-not-you-its-rust_

Rollup merge of #75448 - lcnr:rn-as_local_hir_id, r=davidtwco

2020-08-15T03:07:11+00:00

merge `as_local_hir_id` with `local_def_id_to_hir_id` `as_local_hir_id` was defined as just calling `local_def_id_to_hir_id` and I think that having two different ways to call the same method is somewhat confusing. Don't really care about which of these 2 methods we want to keep. Does this require an MCP, considering that these methods are fairly frequently used?

Tweak output of E0225

2020-08-14T19:08:49+00:00

When encountering multiple non-auto trait bounds suggest creating a new trait and explain what auto-traits are.

Auto merge of #75443 - lcnr:opaque-normalize, r=nikomatsakis

2020-08-13T15:03:40+00:00

allow escaping bound vars when normalizing `ty::Opaque` implements https://github.com/rust-lang/rust/issues/75313#issuecomment-672216146 and fixes #75313 cc @eddyb @RalfJung r? @nikomatsakis

merge `as_local_hir_id` with `local_def_id_to_hir_id`

2020-08-13T14:55:16+00:00