rust/src/librustdoc/html/render.rs, branch 1.37.0

remove unused derives and variants

2019-06-27T01:15:13+00:00

Better handling of the sender channel part in rustdoc file writing

2019-06-21T10:00:49+00:00

Handle fs errors through errors::Handler instead of eprintln and panic

2019-06-21T10:00:49+00:00

Add DocFS layer to rustdoc

2019-06-21T10:00:49+00:00

* Move fs::create_dir_all calls into DocFS to provide a clean extension point if async extension there is needed. * Convert callsites of create_dir_all to ensure_dir to reduce syscalls. * Convert fs::write usage to DocFS.write (which also removes a lot of try_err! usage for easier reading) * Convert File::create calls to use Vec buffers and then DocFS.write in order to consistently reduce syscalls as well, make deferring to threads cleaner and avoid leaving dangling content if writing to existing files.... * Convert OpenOptions usage similarly - I could find no discussion on the use of create_new for that one output file vs all the other files render creates, if link redirection attacks are a concern DocFS will provide a good central point to introduce systematic create_new usage. (fs::write/File::create is vulnerable to link redirection attacks). * DocFS::write defers to rayon for IO on Windows producing a modest speedup: before this patch on my development workstation: $ time cargo +mystg1 doc -p winapi:0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 6m 11s real 6m11.734s Afterwards: $ time cargo +mystg1 doc -p winapi:0.3.7 Compiling winapi v0.3.7 Documenting winapi v0.3.7 Finished dev [unoptimized + debuginfo] target(s) in 49.53s real 0m49.643s I haven't measured how much time is in the compilation logic vs in the IO and outputting etc, but this takes it from frustating to tolerable for me, at least for now.

Rollup merge of #61505 - ebarnard:doc-shrink, r=GuillaumeGomez

2019-06-18T23:51:58+00:00

Only show methods that appear in `impl` blocks in the Implementors sections of trait doc pages In the "Implementors" and "Implementations on Foreign Types" sections, only show methods that appear in the `impl` block for that type. This has the benefit of - Reducing the size of the Iterator page, and other large trait documentation pages. - Retaining documentation on the `impl` blocks and functions in the `impl` blocks. - Indicating which provided methods are overridden. - Making the documentation match the structure of the code being documented. - Being a small change that can be easily backed out if issues arise. A set of Rust stdlib docs build with this change are [available here](https://ebarnard.github.io/2019-06-03-rust-smaller-trait-implementers-docs/). The size of the [`Iterator` doc page](https://ebarnard.github.io/2019-06-03-rust-smaller-trait-implementers-docs/std/iter/trait.Iterator.html) is reduced from 14.4MB (latest nightly) to 724kB. Before: After: cc #55900

rustdoc: deny(unused_lifetimes).

2019-06-11T11:11:59+00:00

Only show methods that appear in the impl block for types in the Implementors and Implementations on Foreign Types sections of trait documentation pages.

2019-06-03T21:11:57+00:00

Rollup merge of #61263 - GuillaumeGomez:valid-html, r=Manishearth

2019-06-01T04:50:02+00:00

Don't generate div inside header (h4/h3/h...) elements Fixes #60865. According to the HTML spec, we're not supposed to put `div` elements inside heading elements (h4/h3/h...). It doesn't change the display as far as I could tell. r? @QuietMisdreavus

Don't generate div inside header (h4/h3/h...) elements

2019-05-29T14:51:48+00:00

Rename "Associated" to "Assoc"

2019-05-26T09:49:02+00:00

We are going to uniform the terminology of all associated items. Methods that may or may not have `self` are called "associated functions". Because `AssociatedFn` is a bit long, we rename `Associated` to `Assoc`.

rust/src/librustdoc/html/render.rs, branch 1.37.0

remove unused derives and variants

Better handling of the sender channel part in rustdoc file writing

Handle fs errors through errors::Handler instead of eprintln and panic

Add DocFS layer to rustdoc

Rollup merge of #61505 - ebarnard:doc-shrink, r=GuillaumeGomez

rustdoc: deny(unused_lifetimes).

Only show methods that appear in the impl block for types in the Implementors and Implementations on Foreign Types sections of trait documentation pages.

Rollup merge of #61263 - GuillaumeGomez:valid-html, r=Manishearth

Don't generate div inside header (h4/h3/h...) elements

Rename "Associated*" to "Assoc*"

Rename "Associated" to "Assoc"