rust/src/librustdoc/html/render/write_shared.rs, branch try-perfhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try-perf2025-09-25T21:19:22+00:00rustdoc: put the toolbar on the all item index2025-09-25T21:19:22+00:00Michael Howellmichael@notriddle.com2025-09-25T21:13:26+00:00urn:sha1:8daad494b11ae5d0e5282be485625687bcf27e37rustdoc-search: search backend with partitioned suffix tree2025-08-15T17:26:03+00:00Michael Howellmichael@notriddle.com2024-11-22T19:58:20+00:00urn:sha1:8511e40e7294e1efcc64b81d43969b6bf0f14c2dImprove path segment joining.2025-07-16T22:37:19+00:00Nicholas Nethercoten.nethercote@gmail.com2025-05-27T05:51:47+00:00urn:sha1:fb7aa9e4fdb88a4833274303899b9801ef924100
There are many places that join path segments with `::` to produce a
string. A lot of these use `join("::")`. Many in rustdoc use
`join_with_double_colon`, and a few use `.joined("..")`. One in Clippy
uses `itertools::join`. A couple of them look for `kw::PathRoot` in the
first segment, which can be important.
This commit introduces `rustc_ast::join_path_{syms,ident}` to do the
joining for everyone. `rustc_ast` is as good a location for these as
any, being the earliest-running of the several crates with a `Path`
type. Two functions are needed because `Ident` printing is more complex
than simple `Symbol` printing.
The commit also removes `join_with_double_colon`, and
`estimate_item_path_byte_length` with it.
There are still a handful of places that join strings with "::" that are
unchanged. They are not that important: some of them are in tests, and
some of them first split a path around "::" and then rejoin with "::".
This fixes one test case where `{{root}}` shows up in an error message.
Auto merge of #142869 - nnethercote:join_path-mini, r=camelid2025-07-08T06:32:37+00:00borsbors@rust-lang.org2025-07-08T06:32:37+00:00urn:sha1:45b80ac21a454d343833aad763ef604510c88375
Use `join_with_double_colon` in `write_shared.rs`.
For consistency. Also, it's faster because `join_with_double_colon` does a better job estimating the allocation size than `join` from `itertools`.
r? `@camelid`
setup CI and tidy to use typos for spellchecking and fix few typos2025-07-03T07:51:06+00:00klensyklensy@users.noreply.github.com2024-12-07T10:51:08+00:00urn:sha1:c76d032f0144b650a438ee1efba89c475e0b115bUse `join_with_double_colon` in `write_shared.rs`.2025-06-22T10:28:48+00:00Nicholas Nethercoten.nethercote@gmail.com2025-06-22T10:27:27+00:00urn:sha1:0cf0f9fc74f7bd1c9f160cc1dbd67c92a9436704
For consistency. Also, it's faster because `join_with_double_colon` does
a better job estimating the allocation size than `join` from
`itertools`.
`Option`s are `Iterator`s2025-06-19T10:26:13+00:00Yotam Ofekyotam.ofek@gmail.com2025-06-18T10:28:32+00:00urn:sha1:2bf66e3887f8ef915a1f92496b1ddf27d847b1eeavoid intermediately collecting into vectors2025-06-19T10:26:13+00:00Yotam Ofekyotam.ofek@gmail.com2025-06-18T09:49:12+00:00urn:sha1:569aa26e7bf7f3742fbd6ab3ea3e3c5f9b8d8a75one less pathbuf allocation2025-06-19T10:26:13+00:00Yotam Ofekyotam.ofek@gmail.com2025-05-24T12:10:55+00:00urn:sha1:867c1d5ebf15b1c710cf892c032ad5ec047b34b9`Result::expect` instead of `match` and `panic!`2025-06-18T09:42:43+00:00Yotam Ofekyotam.ofek@gmail.com2025-05-24T11:56:41+00:00urn:sha1:b2fe858a4e69e51e97d737496e938589b26db709