https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.58.1 2021-11-26T20:03:45+00:00 2021-11-26T20:03:45+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2021-11-25T14:33:38+00:00 urn:sha1:20eda22cbf36b5e9bf9fe28c53790c30fb31c9d3 2021-11-25T16:08:23+00:00 Guillaume Gomez guillaume.gomez@huawei.com 2021-11-25T16:08:23+00:00 urn:sha1:c981d40d43c76267e7b4002e381851f0e92875bf 2021-11-24T21:56:37+00:00 Guillaume Gomez guillaume1.gomez@gmail.com 2021-11-24T21:56:37+00:00 urn:sha1:9390b50ef4dc989be4f2bad5dd958c78b0d7fc7c Reduce prominence of item-infos Fixes #59853 - Remove border. - Reduce size of emoji slightly. - Remove details disclosure for unstable reason. This was inconsistent with our other details disclosures, and the detail revealed was usually better explained by clicking on the issue link. Demo: https://rustdoc.crud.net/jsha/chill-item-info/std/mem/union.MaybeUninit.html#method.slice_assume_init_ref Compare vs: https://doc.rust-lang.org/nightly/std/mem/union.MaybeUninit.html#method.slice_assume_init_ref <img src="https://user-images.githubusercontent.com/220205/142717815-09828c9e-6ff4-445a-8ccc-31e028fd4985.png" width=700> 2021-11-22T22:30:29+00:00 Matthias Krüger matthias.krueger@famsik.de 2021-11-22T22:30:29+00:00 urn:sha1:cb7776758c4ce20e7b20526cc753cf33a9ba6bdf Set color for <a> in a more straightforward way. Previously, we set the default color for <a> tags to black, and then had an override with a bunch of not() clauses to set anchors in docblocks to blue. Instead, we should set the default color for <a> to blue (or equivalent in other themes), and override it for places like the sidebar or search results, where we don't want them to be styled as links. Demo at https://rustdoc.crud.net/jsha/theme-anchor/std/string/struct.String.html. This should result in no visible changes. r? `@GuillaumeGomez` 2021-11-22T10:43:12+00:00 bors bors@rust-lang.org 2021-11-22T10:43:12+00:00 urn:sha1:cd83a437cc2b9c453f39996f664d2cc10611375b Remove styles for details.undocumented The Rust code that generated tags with that class was deleted in 10bafe1975e53769180701508e2b8cd3a3b34a0e. r? `@GuillaumeGomez` 2021-11-22T09:13:27+00:00 Jacob Hoffman-Andrews github@hoffman-andrews.com 2021-11-22T05:10:12+00:00 urn:sha1:a56559df1346c44aa058f3a82785f20230a0468f Previously, we set the default color for <a> tags to black, and then had an override with a bunch of not() clauses to set anchors in docblocks to blue. Instead, we should set the default color for <a> to blue (or equivalent in other themes), and override it for places like the sidebar or search results, where we don't want them to be styled as links. 2021-11-21T07:46:23+00:00 Jacob Hoffman-Andrews github@hoffman-andrews.com 2021-11-21T07:46:23+00:00 urn:sha1:6354b279e2b523776cbb97cd6146a51fa1d2cff5 The Rust code that generated tags with that class was deleted in 10bafe1975e53769180701508e2b8cd3a3b34a0e. 2021-11-20T09:21:15+00:00 Matthias Krüger matthias.krueger@famsik.de 2021-11-20T09:21:15+00:00 urn:sha1:59c9c66bc019bec1c21dd5ac9b74b6b4a3468403 Make scrollbar in the sidebar always visible for visual consistency Fixes #90943. I had to add a background in `dark` and `ayu` themes, otherwise it was looking strange (like an invisible margin). So it looks like this:   Sadly, I wasn't able to add a GUI test to ensure that the scrollbar was always displayed because it seems not possible in puppeteer for whatever reason... I used this method: on small pages (like `lib2/sub_mod/index.html`), comparing `.navbar`'s `clientWidth` with `offsetWidth` (the first doesn't include the sidebar in the computed amount). When checking in the browser, it works fine but in puppeteer it almost never works... In case anyone want to try to solve the bug, here is the puppeteer code: <details> More information about this: I tried another approach which was to get the element in `evaluate` directly (by calling it from `page.evaluate(() => { .. });` directly instead of `parseAssertElemProp.evaluate(e => {...});`. ```js const puppeteer = require('puppeteer'); (async () => { const browser = await puppeteer.launch(); const page = await browser.newPage(); await page.goto("file:///path/rust/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/lib2/sub_mod/index.html"); await page.waitFor(".sidebar"); let parseAssertElemProp = await page.$(".sidebar"); if (parseAssertElemProp === null) { throw '".sidebar" not found'; } await parseAssertElemProp.evaluate(e => { const parseAssertElemPropDict = {"clientWidth": "192", "offsetWidth":"200"}; for (const [parseAssertElemPropKey, parseAssertElemPropValue] of Object.entries(parseAssertElemPropDict)) { if (e[parseAssertElemPropKey] === undefined || String(e[parseAssertElemPropKey]) != parseAssertElemPropValue) { throw 'expected `' + parseAssertElemPropValue + '` for property `' + parseAssertElemPropKey + '` for selector `.sidebar`, found `' + e[parseAssertElemPropKey] + '`'; } } }).catch(e => console.error(e)); await browser.close(); })(); ``` </details> r? ``@jsha`` 2021-11-20T08:10:22+00:00 Jacob Hoffman-Andrews github@hoffman-andrews.com 2021-11-20T06:47:07+00:00 urn:sha1:e6ab982d462994dc21a81561ae03bac476431b96 - Remove border. - Reduce size of emoji slightly. - Remove details disclosure for unstable reason. This was inconsistent with our other details disclosures, and the detail revealed was usually better explained by clicking on the issue link. 2021-11-20T00:09:38+00:00 Matthias Krüger matthias.krueger@famsik.de 2021-11-20T00:09:38+00:00 urn:sha1:c0695bbf6083fae739c259c8d88ef24502e5c089 Improve display of enum variants Use h3 and h4 for the variant name and the "Fields" subheading. Remove the "of T" part of the "Fields" subheading. Remove border-bottom from "Fields" subheading. Move docblock below "Fields" listing. Fixes #90061 Demo: https://jacob.hoffman-andrews.com/rust/xmlparser-updated/xmlparser/enum.Token.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/io/enum.ErrorKind.html#variants https://jacob.hoffman-andrews.com/rust/fix-enum-variants/std/result/enum.Result.html#variants r? ``@camelid``