rust/src/libstd/io/mod.rs, branch 1.43.1https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.43.12020-03-10T05:47:47+00:00Rollup merge of #69514 - GuillaumeGomez:remove-spotlight, r=kinnison2020-03-10T05:47:47+00:00Mazdak Farrokhzadtwingoow@gmail.com2020-03-10T05:47:47+00:00urn:sha1:61150353bf9cc415f4554a9b4851c14e4255329f
Remove spotlight
I had a few comments saying that this feature was at best misunderstood or not even used so I decided to organize a poll about on [twitter](https://twitter.com/imperioworld_/status/1232769353503956994). After 87 votes, the result is very clear: it's not useful. Considering the amount of code we have just to run it, I think it's definitely worth it to remove it.
r? @kinnison
cc @ollie27
Don't redundantly repeat field names (clippy::redundant_field_names)2020-03-06T18:42:18+00:00Matthias Krügermatthias.krueger@famsik.de2020-03-06T18:28:44+00:00urn:sha1:83980aca2086e5c4dca5aae9a92a065a9ff4ac56use char instead of &str for single char patterns2020-02-27T13:57:22+00:00Matthias Krügermatthias.krueger@famsik.de2020-02-26T12:03:46+00:00urn:sha1:7c84ba112429eb9bc0b99a6fe32a453c920a764cRemove spotlight usage2020-02-27T13:51:22+00:00Guillaume Gomezguillaume1.gomez@gmail.com2020-02-27T13:38:30+00:00urn:sha1:13c6d5819aae3c0de6a90e7f17ea967bf4487cbbDocument that write_all will not call write if given an empty buffer2020-01-29T01:22:38+00:00Josh Triplettjosh@joshtriplett.org2020-01-29T01:22:38+00:00urn:sha1:9bb2a50e04460fff646830502d575b82dbf17055
Some types of Write instances have a semantic meaning associated with
writing an empty buffer, such as sending an empty packet. This works
when calling `write` directly, and supplying an empty buffer. However,
calling `write_all` on an empty buffer will simply never call `write`,
because `write_all` assumes it has no work to do.
Document this behavior, to help prospective users of
datagram-packet-style Write instances.
Format the world2019-12-22T22:42:47+00:00Mark Rousskovmark.simulacrum@gmail.com2019-12-22T22:42:04+00:00urn:sha1:a06baa56b95674fc626b3c3fd680d6a65357fe60Require issue = "none" over issue = "0" in unstable attributes2019-12-21T11:16:18+00:00Ross MacArthurross@macarthur.io2019-12-21T11:16:18+00:00urn:sha1:f7256d28d1c2f8340ab5b99df4bdb15aa232f3f3Simplify {IoSlice, IoSliceMut}::advance examples and tests2019-12-05T00:00:00+00:00Tomasz Miąskotomasz.miasko@gmail.com2019-12-05T00:00:00+00:00urn:sha1:92bc35f7b6cb4232be5ac4cc031202c7ad82260b
Remove unnecessary calls to `std::mem::replace` and make variables immutable.
Format libstd with rustfmt2019-11-30T02:43:27+00:00David Tolnaydtolnay@gmail.com2019-11-27T18:29:00+00:00urn:sha1:4436c9d35498e7ae3da261f6141d6d73b915e1e8
This commit applies rustfmt with rust-lang/rust's default settings to
files in src/libstd *that are not involved in any currently open PR* to
minimize merge conflicts. THe list of files involved in open PRs was
determined by querying GitHub's GraphQL API with this script:
https://gist.github.com/dtolnay/aa9c34993dc051a4f344d1b10e4487e8
With the list of files from the script in outstanding_files, the
relevant commands were:
$ find src/libstd -name '*.rs' \
| xargs rustfmt --edition=2018 --unstable-features --skip-children
$ rg libstd outstanding_files | xargs git checkout --
Repeating this process several months apart should get us coverage of
most of the rest of libstd.
To confirm no funny business:
$ git checkout $THIS_COMMIT^
$ git show --pretty= --name-only $THIS_COMMIT \
| xargs rustfmt --edition=2018 --unstable-features --skip-children
$ git diff $THIS_COMMIT # there should be no difference
Fix inconsistent link formatting2019-09-16T12:02:36+00:00Ivan Thampickfire@riseup.net2019-09-16T12:02:36+00:00urn:sha1:62e86b42b5ed342d30c539e22810c26d312995e2