rust/src/libstd/sys/windows/process.rs, branch 1.8.0

std: Push process stdio setup in std::sys

2016-02-10T17:28:48+00:00

Most of this is platform-specific anyway, and we generally have to jump through fewer hoops to do the equivalent operation on Windows. One benefit for Windows today is that this new structure avoids an extra `DuplicateHandle` when creating pipes. For Unix, however, the behavior should be the same. Note that this is just a pure refactoring, no functionality was added or removed.

std: Lift out Windows' CreateProcess lock a bit

2016-02-10T17:28:48+00:00

The function `CreateProcess` is not itself unsafe to call from many threads, the article in question is pointing out that handles can be inherited by unintended child processes. This is basically the same race as the standard Unix open-then-set-cloexec race. Since the intention of the lock is to protect children from inheriting unintended handles, the lock is now lifted out to before the creation of the child I/O handles (which will all be inheritable). This will ensure that we only have one process in Rust at least creating inheritable handles at a time, preventing unintended inheritance to children.

std: Rename Stdio::None to Stdio::Null

2016-02-10T17:28:48+00:00

This better reflects what it's actually doing as we don't actually have an option for "leave this I/O slot as an empty hole".

std: Push Child's exit status to sys::process

2016-02-10T17:28:48+00:00

On Unix we have to be careful to not call `waitpid` twice, but we don't have to be careful on Windows due to the way process handles work there. As a result the cached `Option` is only necessary on Unix, and it's also just an implementation detail of the Unix module. At the same time. also update some code in `kill` on Unix to avoid a wonky waitpid with WNOHANG. This was added in 0e190b9a to solve #13124, but the `signal(0)` method is not supported any more so there's no need to for this workaround. I believe that this is no longer necessary as it's not really doing anything.

std: Refactor process spawning on Unix

2016-02-10T17:28:48+00:00

* Build up the argp/envp pointers while the `Command` is being constructed rather than only when `spawn` is called. This will allow better sharing of code between fork/exec paths. * Rename `child_after_fork` to `exec` and have it only perform the exec half of the spawning. This also means the return type has changed to `io::Error` rather than `!` to represent errors that happen.

std: Properly handle interior NULs in std::process

2016-02-03T15:54:29+00:00

This reports an error at the point of calling `Command::spawn()` or one of its equivalents. Fixes https://github.com/rust-lang/rust/issues/30858 Fixes https://github.com/rust-lang/rust/issues/30862

Auto merge of #31120 - alexcrichton:attribute-deny-warnings, r=brson

2016-01-26T22:10:10+00:00

This commit removes the `-D warnings` flag being passed through the makefiles to all crates to instead be a crate attribute. We want these attributes always applied for all our standard builds, and this is more amenable to Cargo-based builds as well. Note that all `deny(warnings)` attributes are gated with a `cfg(stage0)` attribute currently to match the same semantics we have today

Fix warnings during tests

2016-01-26T17:29:28+00:00

The deny(warnings) attribute is now enabled for tests so we need to weed out these warnings as well.

std: Fix some behavior without stdio handles

2016-01-26T01:48:27+00:00

On all platforms, reading from stdin where the actual stdin isn't present should return 0 bytes as having been read rather than the entire buffer. On Windows, handle the case where we're inheriting stdio handles but one of them isn't present. Currently the behavior is to fail returning an I/O error but instead this commit corrects it to detecting this situation and propagating the non-set handle. Closes #31167

std: Migrate to the new libc

2015-11-10T06:55:50+00:00

* Delete `sys::unix::{c, sync}` as these are now all folded into libc itself * Update all references to use `libc` as a result. * Update all references to the new flat namespace. * Moves all windows bindings into sys::c