rust/src/libstd/sys/windows/process2.rs, branch beta

std: Rename sys::foo2 modules to sys::foo

2015-05-07T16:30:00+00:00

Now that `std::old_io` has been removed for quite some time the naming real estate here has opened up to allow these modules to move back to their proper names.

std: Fix inheriting standard handles on windows

2015-04-29T15:01:16+00:00

Currently if a standard I/O handle is set to inherited on Windows, no action is taken and the slot in the process information description is set to `INVALID_HANDLE_VALUE`. Due to our passing of `STARTF_USESTDHANDLES`, however, this means that the handle is actually set to nothing and if a child tries to print it will generate an error. This commit fixes this behavior by explicitly creating stdio handles to be placed in these slots by duplicating the current process's I/O handles. This is presumably what previously happened silently by using a file-descriptor-based implementation instead of a `HANDLE`-centric implementation. Along the way this cleans up a lot of code in `Process::spawn` for Windows by ensuring destructors are always run, using more RAII, and limiting the scope of `unsafe` wherever possible.

std: Fix process spawn for arguments ending in backslashes on Windows

2015-04-25T19:35:22+00:00

Fix `make_command_line` for the case of backslashes at the end of an argument requiring quotes. We must encode the command and arguments such that `CommandLineToArgvW` recovers them in the spawned process. Simplify the logic by using a running count of backslashes as they are encountered instead of looking ahead for quotes following them. Extend `test_make_command_line` to additionally cover: * a leading quote in an argument that requires quotes, * a backslash before a quote in an argument that requires quotes, * a backslash at the end of an argument that requires quotes, and * a backslash at the end of an argument that does not require quotes.

std: Bring back f32::from_str_radix as an unstable API

2015-04-21T22:23:54+00:00

This API was exercised in a few tests and mirrors the `from_str_radix` functionality of the integer types.

Auto merge of #23682 - tamird:DRY-is-empty, r=alexcrichton

2015-04-16T03:22:21+00:00

r? @alexcrichton

Positive case of `len()` -> `is_empty()`

2015-04-15T03:26:03+00:00

`s/(?

std: Remove final usage of fds from Windows

2015-04-14T20:50:45+00:00

This commit removes the last remnants of file descriptors from the Windows implementation of `std::sys` by using `CreatePipe` to create anonymous pipes instead of the `pipe` shim provided in msvcrt.

std: Unconditionally close all file descriptors

2015-04-10T08:03:38+00:00

The logic for only closing file descriptors >= 3 was inherited from quite some time ago and ends up meaning that some internal APIs are less consistent than they should be. By unconditionally closing everything entering a `FileDesc` we ensure that we're consistent in our behavior as well as robustly handling the stdio case.

Test fixes and rebase conflicts

2015-04-01T07:36:26+00:00

Remove IteratorExt

2015-03-28T20:53:45+00:00

All methods are inlined into Iterator with `Self: Sized` bounds to make sure Iterator is still object safe. [breaking-change]