https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.29.2 2018-07-30T06:29:39+00:00 2018-07-30T06:29:39+00:00 bors bors@rust-lang.org 2018-07-30T06:29:39+00:00 urn:sha1:7bbcd005b30582d07f1a39dcf50f77b54e055828 Don't format!() string literals Prefer `to_string()` to `format!()` take 2, this time targetting string literals. In some cases (`&format!("...")` -> `"..."`) also removes allocations. Occurences of `format!("")` are changed to `String::new()`. 2018-07-29T21:37:47+00:00 bors bors@rust-lang.org 2018-07-29T21:37:47+00:00 urn:sha1:866a713258915e6cbb212d135f751a6a8c9e1c0a Replace push loops with extend() where possible Or set the vector capacity where I couldn't do it. According to my [simple benchmark](https://gist.github.com/ljedrz/568e97621b749849684c1da71c27dceb) `extend`ing a vector can be over **10 times** faster than `push`ing to it in a loop: 10 elements (6.1 times faster): ``` test bench_extension ... bench: 75 ns/iter (+/- 23) test bench_push_loop ... bench: 458 ns/iter (+/- 142) ``` 100 elements (11.12 times faster): ``` test bench_extension ... bench: 87 ns/iter (+/- 26) test bench_push_loop ... bench: 968 ns/iter (+/- 3,528) ``` 1000 elements (11.04 times faster): ``` test bench_extension ... bench: 311 ns/iter (+/- 9) test bench_push_loop ... bench: 3,436 ns/iter (+/- 233) ``` Seems like a good idea to use `extend` as much as possible. 2018-07-29T16:53:22+00:00 ljedrz ljedrz@gmail.com 2018-07-26T15:11:10+00:00 urn:sha1:59c8a279daf6912b99ba089ff6dafbfc3469831e 2018-07-29T09:33:37+00:00 bors bors@rust-lang.org 2018-07-29T09:33:37+00:00 urn:sha1:023fd7e74a9eb5bafcb75fcbe69b7110e9de4492 Prefer to_string() to format!() Simple benchmarks suggest in some cases it can be faster by even 37%: ``` test converting_f64_long ... bench: 339 ns/iter (+/- 199) test converting_f64_short ... bench: 136 ns/iter (+/- 34) test converting_i32_long ... bench: 87 ns/iter (+/- 16) test converting_i32_short ... bench: 87 ns/iter (+/- 49) test converting_str ... bench: 54 ns/iter (+/- 15) test formatting_f64_long ... bench: 349 ns/iter (+/- 176) test formatting_f64_short ... bench: 145 ns/iter (+/- 14) test formatting_i32_long ... bench: 98 ns/iter (+/- 14) test formatting_i32_short ... bench: 93 ns/iter (+/- 15) test formatting_str ... bench: 86 ns/iter (+/- 23) ``` 2018-07-28T15:58:52+00:00 ljedrz ljedrz@gmail.com 2018-07-28T12:40:32+00:00 urn:sha1:421b2ba347a3a1afa41b91f4254f238c790fd73b 2018-07-27T20:27:40+00:00 bors bors@rust-lang.org 2018-07-27T20:27:40+00:00 urn:sha1:4f1e2357447ef7e8066c49560d66c3e18f25d982 Rollup of bare_trait_objects PRs All deny attributes were moved into bootstrap so they can be disabled with a line of config. Warnings for external tools are allowed and it's up to the tool's maintainer to keep it warnings free. r? @Mark-Simulacrum cc @ljedrz @kennytm 2018-07-27T09:11:18+00:00 ljedrz ljedrz@gmail.com 2018-07-27T09:11:18+00:00 urn:sha1:57a5a9b05423c4f832cd9a3aaa7e06d55fab6efa 2018-07-25T01:25:02+00:00 Tatsuyuki Ishi ishitatsuyuki@gmail.com 2018-07-25T01:25:02+00:00 urn:sha1:4f1d4e4db699d674cae5dec3a8026b1388820895 2018-07-25T01:24:31+00:00 Tatsuyuki Ishi ishitatsuyuki@gmail.com 2018-07-13T05:25:22+00:00 urn:sha1:66c4dc9769b7ae456fe2960dc5a1e037b2432184 2018-07-24T22:43:48+00:00 Mark Rousskov mark.simulacrum@gmail.com 2018-07-24T22:43:48+00:00 urn:sha1:28f8cb585aa4953864f64fdc58da9d4a2a34d6c0 Stablize Redox Unix Sockets I don't know if I did this correctly, but I basically spammed the `#[stable]` attribute everywhere :^)