https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.25.0 2018-02-07T16:30:47+00:00 2018-02-07T16:30:47+00:00 Manish Goregaokar manishsmail@gmail.com 2018-02-07T16:30:47+00:00 urn:sha1:aee22556a97aac4b921efb806b26fbb60a6b8a92 Add filtering options to `rustc_on_unimplemented` - Add filtering options to `rustc_on_unimplemented` for local traits, filtering on `Self` and type arguments. - Add a way to provide custom notes. - Tweak binops text. - Add filter to detect wether `Self` is local or belongs to another crate. - Add filter to `Iterator` diagnostic for `&str`. Partly addresses #44755 with a different syntax, as a first approach. Fixes #46216, fixes #37522, CC #34297, #46806. 2018-02-01T23:16:02+00:00 Esteban Küber esteban@kuber.com.ar 2018-02-01T22:16:53+00:00 urn:sha1:fd3f2312a75bcc4c8121ad324a012c3b8befb61c 2018-02-01T23:06:23+00:00 Esteban Küber esteban@kuber.com.ar 2018-02-01T20:12:55+00:00 urn:sha1:378e73e6db0b4d47586f4e3ec975e43ef530ac99 2018-02-01T23:06:22+00:00 Esteban Küber esteban@kuber.com.ar 2018-01-23T03:13:06+00:00 urn:sha1:f7c61783e4cbc169955c7e633ecf629ed901a54e 2018-02-01T23:06:22+00:00 Esteban Küber esteban@kuber.com.ar 2018-01-23T03:03:51+00:00 urn:sha1:27a23db66032be9be96e697fdda50e73b0b90cc5 2018-02-01T23:06:20+00:00 Esteban Küber esteban@kuber.com.ar 2018-01-20T03:57:10+00:00 urn:sha1:c1383e4dc4bd6598f5d73d2d6b1054f61b2b99d4 - filter error on the evaluated value of `Self` - filter error on the evaluated value of the type arguments - add argument to include custom note in diagnostic - allow the parser to parse `Self` when processing attributes - add custom message to binops 2018-01-30T22:00:55+00:00 Jonathan Goodman goodmanjonathan@sbcglobal.net 2018-01-30T20:56:02+00:00 urn:sha1:a99b5db56a36652185a91be630b3e2af8ea09360 2018-01-30T08:23:41+00:00 bors bors@rust-lang.org 2018-01-30T08:23:41+00:00 urn:sha1:fe7e1a45f37f4265434cead827f587e75412f85c syntax: Lower priority of `+` in `impl Trait`/`dyn Trait` Now you have to write `Fn() -> (impl A + B)` instead of `Fn() -> impl A + B`, this is consistent with priority of `+` in trait objects (`Fn() -> A + B` means `(Fn() -> A) + B`). To make this viable I changed the syntax to also permit `+` in return types in function declarations ``` fn f() -> dyn A + B { ... } // OK, don't have to write `-> (dyn A + B)` // This is acceptable, because `dyn A + B` here is an isolated type and // not part of a larger type with various operator priorities in play // like `dyn A + B` in `Fn() -> dyn A + B` despite syntax similarities. ``` but you still have to use `-> (dyn A + B)` in function types and function-like trait object types (see this PR's tests for examples). This can be a breaking change for code using `impl Trait` on nightly. The thing that is most likely to break is `&impl A + B`, it needs to be rewritten as `&(impl A + B)`. cc https://github.com/rust-lang/rust/issues/34511 https://github.com/rust-lang/rust/issues/44662 https://github.com/rust-lang/rfcs/pull/438 2018-01-28T07:44:14+00:00 bors bors@rust-lang.org 2018-01-28T07:44:14+00:00 urn:sha1:7046a406232695b581579f8e2468601260ea2199 Correctly format `extern crate` conflict resolution help Closes #45799. Follow up to @Cldfire's #45820. If the `extern` statement that will have a suggestion ends on a `;`, synthesize a new span that doesn't include it. 2018-01-27T19:38:28+00:00 Vadim Petrochenkov vadim.petrochenkov@gmail.com 2018-01-27T19:37:17+00:00 urn:sha1:f57ea7cb3daf186bcd181f9add9e56cc45ff8380