rust/src/libsyntax_ext/deriving, branch 1.27.1

Remove Option from the return type of Attribute::name()

2018-05-02T09:32:34+00:00

rustc_target: move in syntax::abi and flip dependency.

2018-04-26T14:49:16+00:00

Auto merge of #49986 - zofrex:better-derived-argument-names, r=Manishearth

2018-04-25T01:50:56+00:00

Provide better names for builtin deriving-generated attributes First attempt at fixing #49967 Not in love with any choices here, don't be shy if you aren't happy with anything :) I've tested that this produces nicer names in documentation, and that it no longer has issues conflicting with constants with the same name. (I guess we _could_ make a test for that... unsure if that would be valuable) In all cases I took the names from the methods as declared in the relevant trait. In some cases I had to prepend the names with _ otherwise there were errors about un-used variables. I'm uneasy with the inconsistency... do they all need to be like that? Is there a way to generate an alternate impl or use a different name (`_`?) in the cases where the arguments are not used? Lastly the gensym addition to Ident I implemented largely as suggested, but I want to point out it's a little circuitous (at least, as far as I understand it). `cx.ident_of(name)` is just `Ident::from_str`, so we create an Ident then another Ident from it. `Ident::with_empty_ctxt(Symbol::gensym(string))` may or may not be equivalent, I don't know if it's important to intern it _then_ gensym it. It seems like either we could use that, or if we do want a new method to make this convenient, it could be on Ident instead (`from_str_gensymed`?)

Fix some of the __names in the comments

2018-04-19T19:17:06+00:00

Gensym remaining identifiers

2018-04-19T19:06:35+00:00

Don't prepend deriving-generated attributes with _

2018-04-19T12:57:43+00:00

Provide better names for builtin deriving-generated attributes

2018-04-15T19:51:10+00:00

Auto merge of #49881 - varkor:partialord-opt, r=Manishearth

2018-04-15T03:54:15+00:00

Fix derive(PartialOrd) and optimise final field operation ```rust // Before (`lt` on 2-field struct) self.f1 < other.f1 || (!(other.f1 < self.f1) && (self.f2 < other.f2 || (!(other.f2 < self.f2) && (false) )) ) // After self.f1 < other.f1 || (!(other.f1 < self.f1) && self.f2 < other.f2 ) // Before (`le` on 2-field struct) self.f1 < other.f1 || (!(other.f1 < self.f1) && (self.f2 < other.f2 || (!(other.f2 < self.f2) && (true) )) ) // After self.f1 < other.f1 || (self.f1 == other.f1 && self.f2 <= other.f2 ) ``` (The big diff is mainly because of a past faulty rustfmt application that I corrected 😒) Fixes #49650 and fixes #49505.

Abstract cs_eq for partial_eq

2018-04-12T00:53:21+00:00

Improve the comment for cs_fold1

2018-04-12T00:33:52+00:00