https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=try 2011-05-27T01:21:02+00:00 2011-05-27T01:21:02+00:00 Graydon Hoare graydon@mozilla.com 2011-05-27T01:20:48+00:00 urn:sha1:79c9e130731c6fc471c946fb289a67348749a0b7 2011-05-24T22:52:31+00:00 Rafael Ávila de Espíndola respindola@mozilla.com 2011-05-24T22:52:31+00:00 urn:sha1:de2e84e5b044d8635387bacd37d6088bd8dffd66 2011-05-24T22:29:08+00:00 Rafael Ávila de Espíndola respindola@mozilla.com 2011-05-24T22:23:39+00:00 urn:sha1:ac836dd79c2d7c631ca601dc468de13cb5c785da 2011-05-24T21:28:37+00:00 Rafael Ávila de Espíndola respindola@mozilla.com 2011-05-24T21:28:37+00:00 urn:sha1:b1292580b95ea4a2ab22682ff04a91004c44cd06 2011-05-24T21:00:45+00:00 Rafael Ávila de Espíndola respindola@mozilla.com 2011-05-24T21:00:45+00:00 urn:sha1:0fc91b6ecc975bf508ec631a9fe3ea19e8df4579 2011-05-18T19:43:48+00:00 Rafael Ávila de Espíndola respindola@mozilla.com 2011-05-18T19:43:48+00:00 urn:sha1:96516e9ca263574fa58c2f0a48348fa0d876be10 2011-04-19T14:57:13+00:00 Marijn Haverbeke marijnh@gmail.com 2011-04-19T10:21:57+00:00 urn:sha1:880be6a94013ba0b7791b0ca1b6e16104f2f0a1c See https://github.com/graydon/rust/wiki/Logging-vision The runtime logging categories are now treated in the same way as modules in compiled code. Each domain now has a log_lvl that can be used to restrict the logging from that domain (will be used to allow logging to be restricted to a single domain). Features dropped (can be brought back to life if there is interest): - Logger indentation - Multiple categories per log statement - I possibly broke some of the color code -- it confuses me 2011-04-18T14:21:49+00:00 Marijn Haverbeke marijnh@gmail.com 2011-04-18T14:18:55+00:00 urn:sha1:f6be25a8705b40c2c5127b52479485d904d38b64 Apparently it can't live in the main binary, since on non-Linux platforms, dynamics libs won't find symbols in the binary. This removes the crate_map pointer from rust_crate again, and instead passes it as an extra argument to rust_start. Rustboot doesn't pass this argument, but supposedly that's okay as long as we don't actually use it on that platform. 2011-04-18T13:28:47+00:00 Marijn Haverbeke marijnh@gmail.com 2011-04-17T14:29:18+00:00 urn:sha1:148e6f7b00b89850d46624170b82a932d0302575 This overloads the meaning of RUST_LOG to also allow 'module.submodule' or 'module.somethingelse=2' forms. The first turn on all logging for a module (loglevel 3), the second sets its loglevel to 2. Log levels are: 0: Show only errors 1: Errors and warnings 2: Errors, warnings, and notes 3: Everything, including debug logging Right now, since we only have one 'log' operation, everything happens at level 1 (warning), so the only meaningful thing that can be done with the new RUST_LOG support is disable logging (=0) for some modules. TODOS: * Language support for logging at a specific level * Also add a log level field to tasks, query the current task as well as the current module before logging (log if one of them allows it) * Revise the C logging API to conform to this set-up (globals for per-module log level, query the task level before logging, stop using a global mask) Implementation notes: Crates now contain two extra data structures. A 'module map' that contains names and pointers to the module-log-level globals for each module in the crate that logs, and a 'crate map' that points at the crate's module map, as well as at the crate maps of all external crates it depends on. These are walked by the runtime (in rust_crate.cpp) to set the currect log levels based on RUST_LOG. These module log globals are allocated as-needed whenever a log expression is encountered, and their location is hard-coded into the logging code, which compares the current level to the log statement's level, and skips over all logging code when it is lower. 2011-04-07T22:15:30+00:00 Marijn Haverbeke marijnh@gmail.com 2011-04-07T20:05:45+00:00 urn:sha1:9a7576fe2cdd169313b5e25be6bf485407adb496 No functions should be called for log statements that turn out to be inactive.