rust/src/rustllvm/ArchiveWrapper.cpp, branch 1.25.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.25.02018-01-24T15:18:02+00:00llvm6: Different return value for writeArchive2018-01-24T15:18:02+00:00Alex Crichtonalex@alexcrichton.com2018-01-23T01:59:27+00:00urn:sha1:caedb36f081334451ba83e9524af025891208592
Updated in llvm-mirror/llvm@203c90ba this function now just returns an `Error`,
so this updates the C++ bindings accordingly
llvm6: Remove MIPS64 archive variant2018-01-24T15:18:02+00:00Alex Crichtonalex@alexcrichton.com2018-01-23T01:30:22+00:00urn:sha1:b6fe1127e4b28aded8a1b0f95340e2de7dc12716
It looks like LLVM also removed it in llvm-mirror/llvm@f45adc29d in favor of the
name "GNU64". This was added in the thought that we'd need such a variant when
adding mips64 support but we ended up not needing it! For now let's just
removing the various support on the Rust side of things.
rustllvm: Remove conditional code for LLVM < 3.92017-12-01T22:37:23+00:00Josh Stonejistone@redhat.com2017-12-01T01:28:28+00:00urn:sha1:51342f1fd7f38153003f9780d83babc222139bb1
We bumped the minimum LLVM to 3.9 in #45326. This just cleans up the
conditional code in the rustllvm C++ wrappers to assume at least 3.9.
[rustllvm] Use report_fatal_error over llvm_unreachable2017-11-20T16:47:29+00:00Robin Krupperobin.kruppe@gmail.com2017-11-20T16:47:29+00:00urn:sha1:296aa96deb7e7676455db22dcdbaab83d21736ce
This makes it more robust when assertions are disabled,
crashing instead of causing UB.
Also introduces a tidy check to enforce this rule,
which in turn necessitated making tidy run on src/rustllvm.
Fixes #44020
Fix archive member names on 5.02017-07-21T17:09:11+00:00Alex Crichtonalex@alexcrichton.com2017-07-21T16:41:29+00:00urn:sha1:fb217afe86a5b9fccf8565d2d15afc83fceb91b6Improve naming style in rustllvm.2016-12-31T18:20:30+00:00Ian Kerinsianskerins@gmail.com2016-12-31T17:01:23+00:00urn:sha1:e6f97114ca67ffcd55c81d990f1f239957eb6c00
As per the LLVM style guide, use CamelCase for all locals and classes,
and camelCase for all non-FFI functions.
Also, make names of variables of commonly used types more consistent.
Fixes #38688.
Switching from NULL to nullptr in src/rustllvm.2016-12-30T15:37:05+00:00karpinskimarcinpkarpinski@gmail.com2016-12-30T12:21:21+00:00urn:sha1:72ebc02f13eeb7328d199d7d5ccaee4e5ff03b3eRan clang-format on src/rustllvm with llvm as the coding style.2016-12-30T15:36:50+00:00karpinskimarcinpkarpinski@gmail.com2016-12-30T11:22:11+00:00urn:sha1:c72d859e4f27c4b4c4be349091f5c71058ac1cd4Check *all* errors in LLVMRustArchiveIterator* API2016-12-29T20:10:03+00:00Robin Krupperobin.kruppe@gmail.com2016-12-29T15:55:29+00:00urn:sha1:8d50857a6fd38669d85d85ba5172c6262430f4af
Incrementing the `Archive::child_iterator` fetches and validates the next child.
This can trigger an error, which we previously checked on the *next* call to `LLVMRustArchiveIteratorNext()`.
This means we ignore the last error if we stop iterating halfway through.
This is harmless (we don't access the child, after all) but LLVM 4.0 calls `abort()` if *any* error goes unchecked, even a success value.
This means that basically any rustc invocation that opens an archive and searches through it would die.
The solution implemented here is to change the order of operations, such that
advancing the iterator and fetching the newly-validated iterator happens in the same `Next()` call.
This keeps the error handling behavior as before but ensures all `Error`s get checked.
[LLVM 4.0] Explicitly call constructor of 'llvm::Error'2016-12-11T09:44:19+00:00Dylan McKaydylanmckay34@gmail.com2016-12-11T09:42:32+00:00urn:sha1:6222de3ce4fcb59aeb0516305767f0043cc88f1e
The implicit constructor has been deleted. We should use
Error::success() instead.
The constructor in the LLVM headers mentions that "success" should be
used instead of the deleted constructor for clarity.