rust/src/test/codegen/generator-debug.rs, branch 1.59.0

Improve debug symbol names to avoid ambiguity and work better with MSVC's debugger

2021-06-30T18:10:29+00:00

There are several cases where names of types and functions in the debug info are either ambiguous, or not helpful, such as including ambiguous placeholders (e.g., `{{impl}}`, `{{closure}}` or `dyn _'`) or dropping qualifications (e.g., for dynamic types). Instead, each debug symbol name should be unique and useful: * Include disambiguators for anonymous `DefPathDataName` (closures and generators), and unify their formatting when used as a path-qualifier vs item being qualified. * Qualify the principal trait for dynamic types. * If there is no principal trait for a dynamic type, emit all other traits instead. * Respect the `qualified` argument when emitting ref and pointer types. * For implementations, emit the disambiguator. * Print const generics when emitting generic parameters or arguments. Additionally, when targeting MSVC, its debugger treats many command arguments as C++ expressions, even when the argument is defined to be a symbol name. As such names in the debug info need to be more C++-like to be parsed correctly: * Avoid characters with special meaning (`#`, `[`, `"`, `+`). * Never start a name with `<` or `{` as this is treated as an operator. * `>>` is always treated as a right-shift, even when parsing generic arguments (so add a space to avoid this). * Emit function declarations using C/C++ style syntax (e.g., leading return type). * Emit arrays as a synthetic `array$` type. * Include a `$` in all synthetic types as this is a legal character for C++, but not Rust (thus we avoid collisions with user types).

Remove artificial flag from generator variants

2021-04-30T14:36:08+00:00

- Literally, variants are not artificial. We have `yield` statements, upvars and inner variables in the source code. - Functionally, we don't want debuggers to suppress the variants. It contains the state of the generator, which is useful when debugging. So they shouldn't be marked artificial. - Debuggers may use artificial flags to find the active variant. In this case, marking variants artificial will make debuggers not work properly. Fixes #79009.

Remove redundant `ignore-tidy-linelength` annotations

2021-04-03T20:30:20+00:00

This is step 2 towards fixing #77548. In the codegen and codegen-units test suites, the `//` comment markers were kept in order not to affect any source locations. This is because these tests cannot be automatically `--bless`ed.

Split out async fn and generator test

2020-06-24T22:08:59+00:00

This keeps FileCheck from tripping over unimportant differences in codegen.

Give up on checking filename

2020-06-24T22:08:59+00:00

Generalize generator-debug test a bit

2020-06-24T21:53:30+00:00

Don't be so reliant on particular line ordering (though FileCheck makes this hard in general, IMO). Also disable for MSVC.

Add test for generator debuginfo

2020-06-24T21:53:29+00:00