https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.44.0 2019-05-20T09:44:26+00:00 2019-05-20T09:44:26+00:00 MaulingMonkey git@maulingmonkey.com 2019-05-20T09:44:26+00:00 urn:sha1:0a423a70bb303195f09753dfdc5a7c4e149e29ff 2019-05-20T00:10:48+00:00 MaulingMonkey git@maulingmonkey.com 2019-05-20T00:10:48+00:00 urn:sha1:e33c4415b3a504bd723328a38bce0f14786db61b Several Microsoft debuggers (VS, VS Code, WinDbg, CDB, ...) consume the `*.natvis` files we embed into rust `*.pdb` files. While this only tests CDB, that test coverage should help for all of them. CHANGES src\bootstrap - test.rs: Run CDB debuginfo tests on MSVC targets src\test\debuginfo - issue-13213.rs: CDB has trouble with this, skip for now (newly discovered regression?) - pretty-std.rs: Was ignored, re-enable for CDB only to start with, add CDB tests. - should-fail.rs: Add CDB tests. src\tools\compiletest: - Added "-cdb" option - Added Mode::DebugInfoCdb ("debuginfo-cdb") - Added run_debuginfo_cdb_test[_no_opt] - Renamed Mode::DebugInfoBoth -> DebugInfoGdbLldb ("debuginfo-gdb+lldb") since it's no longer clear what "Both" means. - Find CDB at the default Win10 SDK install path "C:\Program Files (x86)\Windows Kits\10\Debugger\*\cdb.exe" - Ignore CDB tests if CDB not found. ISSUES - `compute_stamp_hash`: not sure if there's any point in hashing `%ProgramFiles(x86)%` - `OsString` lacks any `*.natvis` entries (would be nice to add in a followup changelist) - DSTs (array/string slices) which work in VS & VS Code fail in CDB. - I've avoided `Mode::DebugInfoAll` as 3 debuggers leads to pow(2,3)=8 possible combinations. REFERENCE CDB is not part of the base Visual Studio install, but can be added via the Windows 10 SDK: https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk Installing just "Debugging Tools for Windows" is sufficient. CDB appears to already be installed on appveyor CI, where this changelist can find it, based on it's use here: https://github.com/rust-lang/rust/blob/0ffc57311030a1930edfa721fe57d0000a063af4/appveyor.yml#L227 CDB commands and command line reference: https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/debugger-reference 2018-12-26T04:08:33+00:00 Mark Rousskov mark.simulacrum@gmail.com 2018-12-25T15:56:47+00:00 urn:sha1:2a663555ddf36f6b041445894a8c175cd1bc718c 2018-01-05T10:47:34+00:00 Sam slancia@cisco.com 2018-01-03T18:24:25+00:00 urn:sha1:0a24acda18056dd6bc4a5b8ec1897f5b34d283f4 2017-10-06T19:05:53+00:00 Tom Tromey tom@tromey.com 2017-10-03T19:28:57+00:00 urn:sha1:c3c1df582094b10f803d875f43f6e8b7e3107c5d A few pretty-printers were returning a quoted string from their to_string method. It's preferable in gdb to return a lazy string and to let gdb handle the display by having a "display_hint" method that returns "string" -- it lets gdb settings (like "set print ...") work, it handles corrupted strings a bit better, and it passes the information along to IDEs. 2017-06-09T15:51:28+00:00 gentoo90 gentoo90@gmail.com 2017-06-09T15:51:28+00:00 urn:sha1:d7c0d7569b47298da4a45dfd96275b9a888fe58c 2017-06-02T13:18:00+00:00 gentoo90 gentoo90@gmail.com 2017-06-02T13:18:00+00:00 urn:sha1:c1f687b73fc76808d8f4555d6f77b7f64e554fa9 2017-06-01T18:26:09+00:00 gentoo90 gentoo90@gmail.com 2017-06-01T18:26:09+00:00 urn:sha1:c7ef85ca0eb09acad16d2f969e69737308290309 2016-10-31T20:12:59+00:00 Tim Neumann mail@timnn.me 2016-10-25T21:32:04+00:00 urn:sha1:9253e1206e91f5bd7fafd18f8488a937b0046959 2015-05-30T18:06:08+00:00 Michael Woerister michaelwoerister@posteo 2015-05-09T14:48:36+00:00 urn:sha1:d136714e04fa244fb45a8459cb717dc682208697 GDB and LLDB pretty printers have some common functionality and also access some common information, such as the layout of standard library types. So far, this information has been duplicated in the two pretty printing python modules. This commit introduces a common module used by both debuggers.