rust/src/test/debuginfo, branch 1.37.0 https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.37.0 2019-05-20T09:44:26+00:00 Fix CDB support tidy check line length failures. 2019-05-20T09:44:26+00:00 MaulingMonkey git@maulingmonkey.com 2019-05-20T09:44:26+00:00 urn:sha1:0a423a70bb303195f09753dfdc5a7c4e149e29ff Add basic CDB support to debuginfo compiletest s, to help catch `*.natvis` regressions, like those fixed in #60687. 2019-05-20T00:10:48+00:00 MaulingMonkey git@maulingmonkey.com 2019-05-20T00:10:48+00:00 urn:sha1:e33c4415b3a504bd723328a38bce0f14786db61b Several Microsoft debuggers (VS, VS Code, WinDbg, CDB, ...) consume the `*.natvis` files we embed into rust `*.pdb` files. While this only tests CDB, that test coverage should help for all of them. CHANGES src\bootstrap - test.rs: Run CDB debuginfo tests on MSVC targets src\test\debuginfo - issue-13213.rs: CDB has trouble with this, skip for now (newly discovered regression?) - pretty-std.rs: Was ignored, re-enable for CDB only to start with, add CDB tests. - should-fail.rs: Add CDB tests. src\tools\compiletest: - Added "-cdb" option - Added Mode::DebugInfoCdb ("debuginfo-cdb") - Added run_debuginfo_cdb_test[_no_opt] - Renamed Mode::DebugInfoBoth -> DebugInfoGdbLldb ("debuginfo-gdb+lldb") since it's no longer clear what "Both" means. - Find CDB at the default Win10 SDK install path "C:\Program Files (x86)\Windows Kits\10\Debugger\*\cdb.exe" - Ignore CDB tests if CDB not found. ISSUES - `compute_stamp_hash`: not sure if there's any point in hashing `%ProgramFiles(x86)%` - `OsString` lacks any `*.natvis` entries (would be nice to add in a followup changelist) - DSTs (array/string slices) which work in VS & VS Code fail in CDB. - I've avoided `Mode::DebugInfoAll` as 3 debuggers leads to pow(2,3)=8 possible combinations. REFERENCE CDB is not part of the base Visual Studio install, but can be added via the Windows 10 SDK: https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk Installing just "Debugging Tools for Windows" is sufficient. CDB appears to already be installed on appveyor CI, where this changelist can find it, based on it's use here: https://github.com/rust-lang/rust/blob/0ffc57311030a1930edfa721fe57d0000a063af4/appveyor.yml#L227 CDB commands and command line reference: https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/debugger-reference Address review comments 2019-05-04T02:25:35+00:00 Tyler Mandry tmandry@gmail.com 2019-05-03T23:11:39+00:00 urn:sha1:77a6d29f483c6a1925a90f7e54b0d5721806d8fa Include generator locals as field names in debuginfo 2019-04-25T17:28:09+00:00 Tyler Mandry tmandry@gmail.com 2019-04-18T22:36:16+00:00 urn:sha1:f772c39bf9fb3af982bb9a4728d4fdc7308a8bbd Make generator object debuginfo easier to read 2019-04-25T17:28:09+00:00 Tyler Mandry tmandry@gmail.com 2019-04-18T00:46:40+00:00 urn:sha1:6e2e17d1152d46314b332ecaf11b80786386b919 Describe generator variants in debuginfo 2019-04-25T17:28:09+00:00 Tyler Mandry tmandry@gmail.com 2019-04-13T00:03:03+00:00 urn:sha1:961ba95e5a89a101db38e120468be6224af3f8cc Test debuginfo of different var liveness in generators 2019-04-25T17:12:57+00:00 Tyler Mandry tmandry@gmail.com 2019-03-21T21:35:54+00:00 urn:sha1:9e06f2520088a3ad77018f1f5d4c8d3b90497fb1 Remove unnecessary ignore-tidy-linelength 2019-04-23T10:42:14+00:00 varkor github@varkor.com 2019-04-22T15:15:50+00:00 urn:sha1:62838975d005b01c110a355a6e60cdedc08ecd48 Remove double trailing newlines 2019-04-22T15:57:01+00:00 varkor github@varkor.com 2019-04-22T15:55:33+00:00 urn:sha1:7f0f0e31ecceacfc627440216e559b9625378ecc Rollup merge of #59380 - philipc:thinlto-variant, r=michaelwoerister 2019-03-30T13:14:53+00:00 Mazdak Farrokhzad twingoow@gmail.com 2019-03-30T13:14:53+00:00 urn:sha1:ae2551825dbe5a688d00e1d1e7aa7dbaec274e50 Fix invalid DWARF for enums when using ThinLTO We were setting the same identifier for both the DW_TAG_structure_type and the DW_TAG_variant_part. This becomes a problem when using ThinLTO becauses it uses the identifier as a key for a map of types that is used to delete duplicates based on the ODR, so one of them is deleted as a duplicate, resulting in invalid DWARF. The DW_TAG_variant_part isn't a standalone type, so it doesn't need an identifier. Fix by omitting its identifier. ODR uniquing is [enabled here](https://github.com/rust-lang/rust/blob/f21dee2c6179276321a88a63300dce74ff707e92/src/rustllvm/PassWrapper.cpp#L1101).