https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.24.0 2017-12-07T14:53:49+00:00 2017-12-07T14:53:49+00:00 Alex Crichton alex@alexcrichton.com 2017-12-07T01:59:33+00:00 urn:sha1:17fb43bdc61481ff754fe53e8e8fa589fb8789ee In #46382 the logic around linkage preservation with ThinLTO ws tweaked but the loop that registered all otherwise exported GUID values as "don't internalize me please" was erroneously too conservative and only asking "external" linkage items to not be internalized. Instead we actually want the inversion of that condition, everything *without* "local" linkage to be internalized. This commit updates the condition there, adds a test, and... Closes #46543 2017-10-20T23:08:17+00:00 bors bors@rust-lang.org 2017-10-20T23:08:17+00:00 urn:sha1:6511b4f7ee19fbc2e0dd98fa65f23fa11fece722 rustc: Add `_imp_` symbols later in compilation On MSVC targets rustc will add symbols prefixed with `_imp_` to LLVM modules to "emulate" dllexported statics as that workaround is still in place after #27438 hasn't been solved otherwise. These statics, however, were getting gc'd by ThinLTO accidentally which later would cause linking failures. This commit updates the location we add such symbols to happen just before codegen to ensure that (a) they're not eliminated by the optimizer and (b) the optimizer doesn't even worry about them. Closes #45347 2017-10-18T14:01:29+00:00 Alex Crichton alex@alexcrichton.com 2017-10-17T20:08:13+00:00 urn:sha1:3541ffb668c3b908aa5e3b6ba8a890d56a8360a7 On MSVC targets rustc will add symbols prefixed with `_imp_` to LLVM modules to "emulate" dllexported statics as that workaround is still in place after #27438 hasn't been solved otherwise. These statics, however, were getting gc'd by ThinLTO accidentally which later would cause linking failures. This commit updates the location we add such symbols to happen just before codegen to ensure that (a) they're not eliminated by the optimizer and (b) the optimizer doesn't even worry about them. Closes #45347 2017-10-18T01:46:38+00:00 Alex Crichton alex@alexcrichton.com 2017-10-18T01:45:42+00:00 urn:sha1:d9ecdfe3a7a579b9ec89355168f13760c670d4d4 All tests should now have annotation for *why* they're ignored on emscripten. A few tests no longer need such an annotation as well! Closes #41299 2017-10-15T15:41:26+00:00 Alex Crichton alex@alexcrichton.com 2017-10-11T18:19:59+00:00 urn:sha1:2e1c4cd0f51c28b8cfc003fda67f6641bb4335f2 First the `addPreservedGUID` function forgot to take care of "alias" summaries. I'm not 100% sure what this is but the current code now matches upstream. Next the `computeDeadSymbols` return value wasn't actually being used, but it needed to be used! Together these should... Closes #45195