https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.34.2 2018-12-26T04:08:33+00:00 2018-12-26T04:08:33+00:00 Mark Rousskov mark.simulacrum@gmail.com 2018-12-25T15:56:47+00:00 urn:sha1:2a663555ddf36f6b041445894a8c175cd1bc718c 2017-11-24T10:32:35+00:00 Oliver Schneider git-spam-no-reply9815368754983@oli-obk.de 2017-11-20T12:13:27+00:00 urn:sha1:8937d6a6cfb011d9e1fe6b4a426913dbbf9fd584 2017-09-07T08:26:27+00:00 est31 MTest31@outlook.com 2017-09-07T06:47:13+00:00 urn:sha1:d58281097a3bf14fe1b199c8ba6aee00793e111e Fixes #38384 Most of the Rust community uses 4 spaces for indentation, but there are also tab users of Rust (including myself!). This patch fixes a bug in error printing which mispositions error indicators when near code with tabs. The code attempted to fix the issue by replacing spaces with tabs, but it sadly wasn't enough, as sometimes you may not print spaces but _ or ^ instead. This patch employs the reverse strategy: it replaces each tab with a space, so that the number of _ and ^ and spaces in error indicators below the code snippet line up perfectly. In a study [1] preceeding this patch, we could see that this strategy is also chosen by gcc version 6.3.0. Its not perfect, as the output is not beautiful, but its the easiest to implement. If anyone wants to improve on this, be my guest! This patch is meant as improvement of the status quo, not as perfect end status. It fixes the actual issue of mispositioning error indicators. [1]: https://github.com/rust-lang/rust/issues/38384#issuecomment-326813710