rust/src/test/ui/codemap_tests, branch 1.34.0https://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=1.34.02019-01-24T18:53:43+00:00Fix --compare-mode=nll tests2019-01-24T18:53:43+00:00Esteban Küberesteban@kuber.com.ar2019-01-24T18:53:43+00:00urn:sha1:baa0828ee35475987fd825d8eaf77e009dca2bbeRemove licenses2018-12-26T04:08:33+00:00Mark Rousskovmark.simulacrum@gmail.com2018-12-25T15:56:47+00:00urn:sha1:2a663555ddf36f6b041445894a8c175cd1bc718cRemoved overlapping_spans.{rs,stderr,nll.stderr}.2018-11-05T14:26:02+00:00Felix S. Klock IIpnkfelix@pnkfx.org2018-11-05T13:55:30+00:00urn:sha1:f7ded5dcb6d917f4cd68ec7781c655dbe030f000
This is based on the feedback from estebank:
"""
I believe that test can be removed outright. It'd be impossible for a
new change to go through that breaks this kind of output without it
being picked up by multiple other `stderr` tests. This is an artifact
of the transition period to the "new" output style.
"""
see: https://github.com/rust-lang/rust/issues/52663#issuecomment-422155551
Added tests.2018-11-03T04:09:34+00:00Alexander Regueiroalexreg@me.com2018-10-22T00:58:34+00:00urn:sha1:4751953d5f2cd88243e3fac9a84271ed7a2636b4Clearer later use messages for calls2018-10-03T19:32:38+00:00Matthew Jaspermjjasper1@gmail.com2018-09-29T10:47:47+00:00urn:sha1:bc4f9b848d745022ededdfaa3099158a766e8faa
Give a special message when the later use is from a call. Use the span
of the callee instead of the whole expression. For conflicting borrow
messages say that the later use is of the first borrow.
use structured suggestion for "missing mut" label2018-09-12T21:16:18+00:00Andy Russellarussell123@gmail.com2018-09-12T18:13:40+00:00urn:sha1:d871b8ad4ab15b7003cd6aad4b5f361ef6d35fd8
Fixes #54133.
Bless UI tests2018-08-15T22:14:21+00:00ashtneoiashtneoi@gmail.com2018-08-13T23:45:40+00:00urn:sha1:9a0020a8794d8bcb7551e3c22bb345ee3c2b4343Point at correct span when missing comma in `println`2018-08-07T03:54:51+00:00Esteban Küberesteban@kuber.com.ar2018-08-07T03:54:51+00:00urn:sha1:cce4ea5149e28b938d0af8466dd9af1e489f1b55NLL: On "cannot move out of type" error, print original source before rewrite.2018-07-31T15:27:29+00:00Felix S. Klock IIpnkfelix@pnkfx.org2018-07-31T15:22:12+00:00urn:sha1:a5a3f765eb36aee69bfdaba1f82760973b63c780
* Arguably this change is sometimes injecting noise into the output
(namely in the cases where the suggested rewrite is inline with the
suggestion and we end up highlighting the original source code).
I would not be opposed to something more aggressive/dynamic, like
revising the suggestion code to automatically print the original
source when necessary (e.g. when the error does not have a span
that includes the span of the suggestion).
* Also, as another note on this change: The doc comment for `Diagnostic::span_suggestion`
says:
/// The message
///
/// * should not end in any punctuation (a `:` is added automatically)
/// * should not be a question
/// * should not contain any parts like "the following", "as shown"
but the `:` is *not* added when the emitted line appears
out-of-line relative to the suggestion. I find that to be an
unfortunate UI experience.
----
As a drive-by fix, also changed code to combine multiple suggestions
for a pattern into a single multipart suggestion (which vastly
improves user experience IMO).
----
Includes the updates to expected NLL diagnostics.
Match errors using the callsite of macro expansions2018-07-23T12:31:06+00:00Federico Polifederpoli@gmail.com2018-07-19T12:15:43+00:00urn:sha1:8ec9d7242c3352fbc617d907bec3632215811356