https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.52.0 2020-03-11T19:35:46+00:00 2020-03-11T19:35:46+00:00 Aaron Hill aa1ronham@gmail.com 2020-03-11T19:35:46+00:00 urn:sha1:ff65bffe2b143528ff90d5226b18ceca750d7c02 Fixes #66667 Previously, we called `tcx.typeck_tables_of` when determining whether or not to emit a suggestion for a type error. However, we might already be type-checking the `DefId` we pass to `typeck_tables_of` (it could be anywhere in the query stack). Fortunately, we only need the function signature, not the entire `TypeckTables`. By using `tcx.fn_sig`, we avoid the possibility of cycle errors while retaining the ability to emit a suggestion.