rust/src/test/ui/numeric/numeric-fields.stderr, branch tryhttps://github.com/rust-lang/rust
http://git.dreamy.place/mirrors/rust/atom?h=try2023-01-11T09:32:08+00:00Move /src/test to /tests2023-01-11T09:32:08+00:00Albert Larsan74931857+albertlarsan68@users.noreply.github.com2023-01-05T08:13:28+00:00urn:sha1:cf2dff2b1e3fa55fa5415d524200070d0d7aacfeSuggest replacing an inexisting field for an unmentioned field2021-09-13T12:16:05+00:00Hirochika Matsumotogit@hkmatsumoto.com2021-08-12T10:10:44+00:00urn:sha1:37196e36918536de06e64bd2a08b9e5fcab898fa
This PR adds a suggestion to replace an inexisting field for an
unmentioned field. Given the following code:
```rust
enum Foo {
Bar { alpha: u8, bravo: u8, charlie: u8 },
}
fn foo(foo: Foo) {
match foo {
Foo::Bar {
alpha,
beta, // `bravo` miswritten as `beta` here.
charlie,
} => todo!(),
}
}
```
the compiler now emits the error messages below.
```text
error[E0026]: variant `Foo::Bar` does not have a field named `beta`
--> src/lib.rs:9:13
|
9 | beta, // `bravo` miswritten as `beta` here.
| ^^^^
| |
| variant `Foo::Bar` does not have this field
| help: `Foo::Bar` has a field named `bravo`: `bravo`
```
Note that this suggestion is available iff the number of inexisting
fields and unmentioned fields are both 1.
Ensure suggestion is in its own diagnostic window2021-09-02T03:20:46+00:00Noah Levcamelidcamel@gmail.com2021-09-02T03:20:46+00:00urn:sha1:2226977a875c149effeb7d6b85bce5a5ba0c440c
For two reasons:
1. Now that the suggestion span has been corrected, the output is a bit
cluttered and hard to read. Putting the suggestion its own window
creates more space.
2. It's easier to see what's being suggested, since now the version
after the suggestion is applied is shown.
Fix span used for structured tuple struct suggestion2021-09-02T03:17:15+00:00Noah Levcamelidcamel@gmail.com2021-09-02T03:11:05+00:00urn:sha1:d2b13ba46694b73cf2cd64b3a18c3abd55983f2b
(And same for tuple variants.)
Previously, the span was just for the constructor name, which meant it
would result in syntactically-invalid code when applied. Now, the span
is for the entire expression.
typeck: Emit structured suggestions for tuple struct syntax2021-02-04T19:58:55+00:00Camelidcamelidcamel@gmail.com2021-02-04T05:29:00+00:00urn:sha1:ed6232927b5d2f198ec33f77f0eb597a9eb68aa8
And tuple variant syntax, but that didn't fit in the subject :)
Now the fact that these are suggestions is exposed both to the layout
engine and to IDEs and rustfix for automatic application.
fix indentation2019-06-19T17:47:52+00:00Cedriccedric.brancourt@gmail.com2019-06-19T17:47:52+00:00urn:sha1:b72b1ac062a66819cd06a3f147486678e99b4f40provide variant definition on tuple struct unknow field error2019-06-19T09:09:17+00:00Cedriccedric.brancourt@gmail.com2019-06-19T09:09:17+00:00urn:sha1:70e52f84186ee017d19d26e081ab8688beee9b37adt hint pointing to adt span2019-06-19T08:07:07+00:00Cedriccedric.brancourt@gmail.com2019-06-19T08:07:07+00:00urn:sha1:c917ba325f3e7944eefb5e906ca0392c9b499541suggest tuple struct syntax2019-06-17T18:04:26+00:00Cedriccedric.brancourt@gmail.com2019-06-17T18:04:26+00:00urn:sha1:f7ecf1c54806d0a2b614510b46d1b25c178450f0hide `--explain` hint if error has no extended info2019-04-18T17:29:28+00:00Andy Russellarussell123@gmail.com2019-04-17T17:26:38+00:00urn:sha1:b6f148c8bdf2dd1beb11445441366934f8b61f74