https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.82.0 2024-06-25T15:50:48+00:00 2024-06-25T15:50:48+00:00 xFrednet xFrednet@gmail.com 2024-02-10T22:31:36+00:00 urn:sha1:48310525bd79636964ff09bff63c89bf6c9c2dda 2024-02-27T14:50:17+00:00 Philipp Krones hello@philkrones.com 2024-02-27T14:25:18+00:00 urn:sha1:ad7513e8743647dc93f0f3703cce9b9f1403df08 2024-01-30T21:25:29+00:00 Nicholas Nethercote n.nethercote@gmail.com 2024-01-30T05:57:29+00:00 urn:sha1:4225a1e186afe39c1ae81c5065d24287d6d49fb9 `Diagnostic::keys`, which is used for hashing and equating diagnostics, has a surprising behaviour: it ignores children, but only for lints. This was added in #88493 to fix some duplicated diagnostics, but it doesn't seem necessary any more. This commit removes the special case and only four tests have changed output, with additional errors. And those additional errors aren't exact duplicates, they're just similar. For example, in src/tools/clippy/tests/ui/same_name_method.rs we currently have this error: ``` error: method's name is the same as an existing method in a trait --> $DIR/same_name_method.rs:75:13 | LL | fn foo() {} | ^^^^^^^^^^^ | note: existing `foo` defined here --> $DIR/same_name_method.rs:79:9 | LL | impl T1 for S {} | ^^^^^^^^^^^^^^^^ ``` and with this change we also get this error: ``` error: method's name is the same as an existing method in a trait --> $DIR/same_name_method.rs:75:13 | LL | fn foo() {} | ^^^^^^^^^^^ | note: existing `foo` defined here --> $DIR/same_name_method.rs:81:9 | LL | impl T2 for S {} | ^^^^^^^^^^^^^^^^ ``` I think printing this second argument is reasonable, possibly even preferable to hiding it. And the other cases are similar. 2023-09-04T12:22:02+00:00 Urgau urgau@numericable.fr 2023-08-01T12:02:21+00:00 urn:sha1:9190e960e1c6b2c2e73c23e85545656ab1577761 2023-08-24T19:32:12+00:00 Philipp Krones hello@philkrones.com 2023-08-24T19:32:12+00:00 urn:sha1:7137a09806171e75b54c5fb70bf629a55ff04d8b 2022-10-01T10:03:06+00:00 Maybe Waffle waffle.lapkin@gmail.com 2022-09-22T16:04:22+00:00 urn:sha1:9d388dc390bbf520c04b2d76f19045bb0eaa1a57 2022-06-16T15:39:06+00:00 flip1995 hello@philkrones.com 2022-06-16T15:39:06+00:00 urn:sha1:7f605496e75141b473827f3b8d5cdeb17e9f3408 2022-04-08T15:59:59+00:00 Miguel Guarniz mi9uel9@gmail.com 2022-04-03T19:50:33+00:00 urn:sha1:b73b4de982a16e8819e804cb648ff3ea63d22028 - Create hir_crate_items query which traverses tcx.hir_crate(()).owners to return a hir::ModuleItems - use tcx.hir_crate_items in tcx.hir().items() to return an iterator of hir::ItemId - add par_items(impl Fn(hir::ItemId)) to traverse all items in parallel Signed-off-by: Miguel Guarniz <mi9uel9@gmail.com> 2021-12-06T11:33:31+00:00 flip1995 philipp.krones@embecosm.com 2021-12-06T11:33:31+00:00 urn:sha1:f004a1b3fda522694f9857a4ae95eb9ef7baa0c4 2021-09-28T17:03:12+00:00 flip1995 philipp.krones@embecosm.com 2021-09-28T17:03:12+00:00 urn:sha1:d0fb9db6482b534473bd6d54013937580688ff3e