https://github.com/rust-lang/rust http://git.dreamy.place/mirrors/rust/atom?h=1.52.0 2021-02-09T08:39:20+00:00 2021-02-09T08:39:20+00:00 Ömer Sinan Ağacan omeragacan@gmail.com 2021-02-09T08:15:53+00:00 urn:sha1:c4e3558b8c8af8ced8ea3b4b018bc6bccbb0ff73 This renames the variants in HIR UnOp from enum UnOp { UnDeref, UnNot, UnNeg, } to enum UnOp { Deref, Not, Neg, } Motivations: - This is more consistent with the rest of the code base where most enum variants don't have a prefix. - These variants are never used without the `UnOp` prefix so the extra `Un` prefix doesn't help with readability. E.g. we don't have any `UnDeref`s in the code, we only have `UnOp::UnDeref`. - MIR `UnOp` type variants don't have a prefix so this is more consistent with MIR types. - "un" prefix reads like "inverse" or "reverse", so as a beginner in rustc code base when I see "UnDeref" what comes to my mind is something like "&*" instead of just "*". 2020-08-28T16:43:25+00:00 flip1995 hello@philkrones.com 2020-08-28T14:10:16+00:00 urn:sha1:adc7351fb027494ede35d6d3abd7ca02a11c33ce 2020-08-11T15:50:45+00:00 flip1995 hello@philkrones.com 2020-08-11T13:43:21+00:00 urn:sha1:d6b991d3a0b8af4b5f2612b8ac2a4122da8c79bb 2020-05-02T07:49:00+00:00 Oliver Scherer github35764891676564198441@oli-obk.de 2020-05-02T07:49:00+00:00 urn:sha1:bce9fae97abb255c9fc6c994f50a052be4010a6f git-subtree-dir: src/tools/clippy git-subtree-mainline: 06c44816c1532e5ff08ad072f581fc068eb60e2e git-subtree-split: d2708873ef711ec8ab45df1e984ecf24a96cd369